[devel] Review Request: OpenSAF Extensions PR for SC absence with pointers to PR

Hi Anders, I have created a section 6 primarily to give an outline and structure to the topic of 'sc absence'. Have provided pointers to individual service specific PRs. This could be the first stab. Let me know your thoughts. Will also change the name of the READMEs of LOG and CKPT to have the

Re: [devel] [PATCH 1 of 1] smf: Delete node group if already exist when creating [#2049]

ACK, with comments On 09/23/2016 10:55 AM, Lennart Lund wrote: > My own review comments: > > See [Lennart] inline > > /Lennart > >> -Original Message- >> From: Lennart Lund [mailto:lennart.l...@ericsson.com] >> Sent: den 22 september 2016 17:04 >> To: Rafael Odzakow ; >> reddy.neelaka...@

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

ACK with previous comments On 09/23/2016 10:48 AM, Lennart Lund wrote: > My own comments: > > 1) > Do not set m_errno in object delete method. Not used, not needed. Instead use > internal ais_rc where needed > > See also [Lennart] inline > > /Lennart > >> -Original Message- >> From: Lenn

Re: [devel] Review request for Doc: Extensions PR document for 5.1

Ack, Let me push it now, so that my changes go on top of that. Mathi. > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Tuesday, September 20, 2016 7:00 PM > To: opensaf-devel@lists.sourceforge.net; Mathivanan Naickan Palanivelu > Subject: Review reque

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

Hi Minh, You can float the patch in parallel. Thanks -Nagu > -Original Message- > From: minh chau [mailto:minh.c...@dektech.com.au] > Sent: 23 September 2016 14:54 > To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya; > gary@dektech.com.au; long.hb.n

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

Hi, See my comment/reply inline [Lennart] Thanks Lennart > -Original Message- > From: Rafael Odzakow > Sent: den 23 september 2016 10:34 > To: Lennart Lund ; > reddy.neelaka...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 1 of 1] smf: Recreate IMM handles if

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

Hi Nagu, Thanks for your update, I hope I could float the patch so everyone can do code review, but let's wait for your testing first. Thanks, Minh On 22/09/16 21:22, Nagendra Kumar wrote: > Hi Minh, > > I have tested following scenarios till now and works well: > 1. Faults under standalone s

Re: [devel] [PATCH 1 of 1] smf: Delete node group if already exist when creating [#2049]

My own review comments: See [Lennart] inline /Lennart > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: den 22 september 2016 17:04 > To: Rafael Odzakow ; > reddy.neelaka...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [devel] [PATCH

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

My own comments: 1) Do not set m_errno in object delete method. Not used, not needed. Instead use internal ais_rc where needed See also [Lennart] inline /Lennart > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: den 22 september 2016 15:34 > To: Rafae

Re: [devel] [PATCH 2 of 2] AMF: Update README for SC Absence feature [#2033]

Ack from me for README and PR doc. Thanks, Praveen On 22-Sep-16 10:50 AM, Minh Hon Chau wrote: > osaf/services/saf/amf/README_HEADLESS | 151 > + > 1 files changed, 76 insertions(+), 75 deletions(-) > > > Rephrase Headless to SC absence, plus documentation f

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

comments one comment under [rafael] tag. On 09/22/2016 03:33 PM, Lennart Lund wrote: > osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 49 > + > 1 files changed, 33 insertions(+), 16 deletions(-) > > > Fix the deleteNodeGroup() method must be so that if the delete op

[devel] [PATCH 1 of 1] imm: Do not send ccb abort reply to clients if they are not in CCB call [#2010]

osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) If the ccb is in CCB_READY/CCB_VALIDATED/CCB_COMMITTED/CCB_ABORTED, the client is not invoking any ccb call. We do not send ccb abort reply to clients in that case. In case of timeout, it's alrea

[devel] [PATCH 0 of 1] Review Request for imm: Do not send ccb abort reply to clients if they are not in CCB call [#2010]

Summary: imm: Do not send ccb abort reply to clients if they are not in CCB call [#2010] Review request for Trac Ticket(s): 2010 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.0, 5.1, 5.2 Development branch: 5.2 Impacted area Impact y/

Re: [devel] [PATCH 2 of 2] AMFD: Fix double start timer of AVD_TMR_CL_INIT [#2036]

Hi Nagu, Please let me know what particular thing that concerns you with (1), or do you agree if I do like (2)? Thanks, Minh On 23/09/16 16:27, minh chau wrote: > Hi Nagu, > > The macro m_AVD_CLINIT_TMR_START has the setting *is_active = false*, > so if this macro is called again without check

Re: [devel] [PATCH 0 of 2] Review Request for AMF: Update README for SC Absence feature [#2033]

Hi all, Do you have any comments on this documentation change? Thanks, Minh On 22/09/16 15:20, Minh Hon Chau wrote: > Summary: AMF: Update README for SC Absence feature [#2033] > Review request for Trac Ticket(s): 2033 > Peer Reviewer(s): AMF devs > Pull request to: <> > Affected branch(es): 5.1