[devel] [PATCH 0 of 1] Review Request for smf:retry for TIMEOUT in si-swap to be avoided [#2069]

Summary: smf:retry for TIMEOUT in si-swap to be avoided [#2069] Review request for Trac Ticket(s): 2069 Peer Reviewer(s): Lennart, Rafel Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impacted area Impact y/n --

[devel] [PATCH 1 of 1] smf:retry for TIMEOUT in si-swap to be avoided [#2069]

osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc b/osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc --- a/osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc +++ b/

Re: [devel] [PATCH 0 of 1] Review Request for smf:retry for TIMEOUT in si-swap to be avoided [#2069]

ACK On 09/27/2016 09:20 AM, reddy.neelaka...@oracle.com wrote: > Summary: smf:retry for TIMEOUT in si-swap to be avoided [#2069] > Review request for Trac Ticket(s): 2069 > Peer Reviewer(s): Lennart, Rafel > Affected branch(es): 5.0.x, 5.1.x, default > Development branch: default > >

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

Hi Lennart, Reviewed the patch, I have to NACK the patch because of the comments. Following are the comments: 1. The retries can not be infinite, while(1) has to be changed to some finite number of retries. 2. make saImmOiFinalize as part of getAllImmHandles. (for more information look into a

Re: [devel] [PATCH 1 of 1] imm:abort the uncommited ccbs when the implementer gracefully disconnects [#2056]

Hi Neel, Reviewed and tested the patch. Ack from me. BR, Hung Nguyen - DEK Technologies From: Neelakanta Reddy reddy.neelaka...@oracle.com Sent: Monday, September 26, 2016 4:19PM To: Zoran Milinkovic, Hung Nguyen

Re: [devel] [PATCH 1 of 1] smf: Delete node group if already exist when creating [#2049]

Hi Lennart, Reviewed the patch. Following are the comments: 1. Do not use infinite loops like while(true), In this case while loop is not required. 2. comments inline. Thanks, Neel. On 2016/09/22 08:34 PM, Lennart Lund wrote: > osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 51 > ++

Re: [devel] [PATCH 1 of 1] smf:retry for TIMEOUT in si-swap to be avoided [#2069]

Hi Neel I can see a problem here. If a timeout there are two possibilities that the SI-swap has been done or the DI-swap is not done. >From AIS spec: "SA_AIS_ERR_TIMEOUT - An implementation-dependent timeout occurred, or the timeout, specified by the timeout parameter, occurred before the call co

Re: [devel] [PATCH 1 of 1] imm: Do not send ccb abort reply to clients if they are not in CCB call [#2010]

Hi Hung, Reviewed the patch. Ack. /Neel. On 2016/09/23 01:18 PM, Hung Nguyen wrote: > osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > If the ccb is in CCB_READY/CCB_VALIDATED/CCB_COMMITTED/CCB_ABORTED, > the client is not invoking an

Re: [devel] [PATCH 2 of 2] AMFD: Fix double start timer of AVD_TMR_CL_INIT [#2036]

Hi Gary/Minh, I think, comments can be taken up as a part of refactoring later. Ack from me, for both the patches. Thanks, Praveen On 23-Sep-16 5:33 AM, Minh Hon Chau wrote: > osaf/services/saf/amf/amfd/include/timer.h | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > > Since the A

Re: [devel] OpenSAF 5.1.RC2 tagged, change control applies

Also adding ticket 2063 to the list of approved tickets for the 5.1.0 release. regards, Anders Widell On 09/22/2016 03:51 PM, Anders Widell wrote: > Hi! > > Ticket 2043 has now also been approved to be pushed on the maintenance > branches before the 5.1.0 release. > > regards, > > Anders Wide

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

Hi Neel, See my comments/answers inline [Lennart] Thanks Lennart > -Original Message- > From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] > Sent: den 27 september 2016 11:04 > To: Lennart Lund ; Rafael Odzakow > > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 1

Re: [devel] [PATCH 1 of 1] smf: Delete node group if already exist when creating [#2049]

Hi Neel See my comments/answer tagged [Lennart] Thanks Lennart > -Original Message- > From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] > Sent: den 27 september 2016 11:21 > To: Lennart Lund ; Rafael Odzakow > > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 1 o

Re: [devel] [PATCH 1 of 1] smf:retry for TIMEOUT in si-swap to be avoided [#2069]

Hi Lennart, On 2016/09/27 02:57 PM, Lennart Lund wrote: > Hi Neel > > I can see a problem here. If a timeout there are two possibilities that the > SI-swap has been done or the DI-swap is not done. > From AIS spec: > "SA_AIS_ERR_TIMEOUT - An implementation-dependent timeout occurred, or the > t

Re: [devel] [PATCH 1 of 1] smf: Recreate IMM handles if bad handle when deleting node group [#2046]

Hi Lennart, comments inline. On 2016/09/27 04:58 PM, Lennart Lund wrote: > Hi Neel, > > See my comments/answers inline [Lennart] > > Thanks > Lennart > >> -Original Message- >> From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] >> Sent: den 27 september 2016 11:04 >> To: Lennart

Re: [devel] [PATCH 1 of 1] smf: Delete node group if already exist when creating [#2049]

Hi Leenart, returning of ERR_EXIST is very rare, and not as frequent as BAD_HANDLE. Still, not satisfied with infinite loop, without finite re-trys. Ack from me. Thanks, Neel. On 2016/09/27 05:14 PM, Lennart Lund wrote: > Hi Neel > > See my comments/answer tagged [Lennart] > > Thanks > Lennart

[devel] [PATCH 1 of 1] log: fix runtime log stream is deleted after restarting from headless [#2071]

osaf/services/saf/logsv/lgs/lgs_evt.cc | 54 +- 1 files changed, 27 insertions(+), 27 deletions(-) Did not look up in recovery list for openning streams, then there was case the openning log stream did not exist in stream database but existing in recovery list. S

[devel] [PATCH 0 of 1] Review Request for log: fix runtime log stream is deleted after restarting from headless [#2071]

Summary: log: fix runtime log stream is deleted after restarting from headless [#2071] Review request for Trac Ticket(s): #2071 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): 5.1, default Development branch: default Impacted area

[devel] [PATCH 1 of 1] amfnd: send recovery request to amfd for term-failed PI su [#2047]

osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 + osaf/services/saf/amf/amfnd/su.cc | 13 + osaf/services/saf/amf/amfnd/susm.cc | 36 +++--- 3 files changed, 45 insertions(+), 5 deletions(-) A SU having one NPI and one PI comp moved to ter

[devel] [PATCH 0 of 1] Review Request for amfnd: send recovery request to amfd for term-failed PI su [#2047]

Summary: amfnd: send recovery request to amfd for term-failed PI su [#2047] Review request for Trac Ticket(s): #2047 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n --

Re: [devel] [PATCH 1 of 1] smf: Delete node group if already exist when creating [#2049]

Hi Neel I have updated the patches based on your comments and will send them for re-review today Thanks Lennart > -Original Message- > From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] > Sent: den 27 september 2016 14:25 > To: Lennart Lund ; Rafael Odzakow > > Cc: opensaf-dev

[devel] [PATCH 1 of 1] clm: add support for cluster reboot V2 [#2053]

osaf/libs/common/clmsv/include/clmsv_msg.h | 6 +++ osaf/libs/core/common/include/osaf_utility.h | 5 +++ osaf/libs/core/common/osaf_utility.c | 16 + osaf/services/saf/clmsv/clms/clms.h | 3 +- osaf/services/saf/clmsv/clms/clms_imm.c | 18 ++ osaf/s

[devel] [PATCH 0 of 1] Review Request for clm: add support for cluster reboot V2 [#2053]

Summary: clm: add support for cluster reboot V2 Review request for Trac Ticket(s): #2053 Peer Reviewer(s): AndersW, Mathi Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Do

[devel] [PATCH 1 of 1] amfd: fix cppcheck errors [#2077]

osaf/libs/common/amf/include/amf_db_template.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osaf/libs/common/amf/include/amf_db_template.h b/osaf/libs/common/amf/include/amf_db_template.h --- a/osaf/libs/common/amf/include/amf_db_template.h +++ b/osaf/libs/common/amf

[devel] [PATCH 0 of 1] Review Request for amfd: fix cppcheck errors [#2077]

Summary: amfd: fix cppcheck errors Review request for Trac Ticket(s): #2077 Peer Reviewer(s): Nagu, Praveen, Gary Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Docs

[devel] OpenSAF 5.1.0, 5.0.1 and 4.7.2 released

Hi all! Today we have announced the general availability of the OpenSAF 5.1.0 release, together with the maintenance releases 5.0.1 and 4.7.2. Since we only maintain three branches, this marks the end of life for the opensaf-4.7.x branch. That branch has been closed in the Mercurial repository

Re: [devel] [PATCH 1 of 1] amfd: fix cppcheck errors [#2077]

Hi Hans ack Thanks Gary > On 28 Sep. 2016, at 2:57 am, Hans Nordeback > wrote: > > osaf/libs/common/amf/include/amf_db_template.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/osaf/libs/common/amf/include/amf_db_template.h > b/osaf/libs/common/amf/include/

Re: [devel] [PATCH 1 of 1] cpsv: remove longDnsAllowed checking each checkpoint creating time [#2068]

Dear Mahesh, osaf_is_an_extended_name() is just a function to check inside SaNameT struct and does not affect performance. cpnd_get_longDnsAllowed_attr() check imm config and cost very much unnecessary time, Imm verify long DN support after that. Thank you and best regards, Hoang -Original

[devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 +++ tests/ntfsv/tet_saNtfNotificationSubscribe.c | 32 + 3 files changed, 81 insertions(+), 21 deletions(-) In finalize(), ntfa deletes client and does n

[devel] [PATCH 0 of 1] Review Request for ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

Summary: ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978] Review request for Trac Ticket(s): #1978 Peer Reviewer(s): Minh, Praveen Pull request to: Praveen Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impac

Re: [devel] [PATCH 1 of 1] amfd: fix cppcheck errors [#2077]

Ack. Thanks, Praveen On 27-Sep-16 10:27 PM, Hans Nordeback wrote: > osaf/libs/common/amf/include/amf_db_template.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/osaf/libs/common/amf/include/amf_db_template.h > b/osaf/libs/common/amf/include/amf_db_template.h >

[devel] [PATCH 0 of 1] Review Request for smf:retry of Admin operation for TIMEOUT in si-swap to be avoided [#2069]

Summary: smf:retry of Admin operation for TIMEOUT in si-swap to be avoided [#2069] Review request for Trac Ticket(s): 2069 Peer Reviewer(s): Lennart, Rafel Affected branch(es): 5.0.x,5.1.x, default Development branch: default Impacted area Impact y/n ---

[devel] [PATCH 1 of 1] smf:retry of Admin operation for TIMEOUT in si-swap to be avoided [#2069]

osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) For the si-swap operation if TIMEOUT occurs the and the node is active the campaign will fail. If the node is standby SmfCampaignThread::instance() will be terminated at Quie