Hi,
the design can be more general, WaitForFileCreation/Deletion can be change to
WaitForEvent(Events, timeout),
where Events contains filename + filedescriptors. When an event happens it will
be returned.
/Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@erics
Hi,
The FIFO is created for each daemon (reading and non blocking), perhaps it
should be created for osafdtmd only, or?
/Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 22 oktober 2016 14:54
To: Anders Widell ; mahesh.va...@oracle.com;
Hi Hung,
Reviewed and tested the patch.
Ack.
/Neel.
On 2016/10/21 10:08 AM, Hung Nguyen wrote:
> osaf/services/saf/immsv/immd/immd_cb.h| 4 +-
> osaf/services/saf/immsv/immd/immd_main.c | 2 +-
> osaf/services/saf/immsv/immd/immd_mbcsv.c | 32
> +++---
> o
Summary: amfd: ignore node_up until the mds event amfnd up has been received
[#2124]
Review request for Trac Ticket(s): 2124
Peer Reviewer(s): <>
Pull request to: <>
Affected branch(es): all
Development branch: default
Impacted area Impact y/n
--
osaf/services/saf/amf/amfd/include/node.h | 1 +
osaf/services/saf/amf/amfd/main.cc| 1 +
osaf/services/saf/amf/amfd/mds.cc | 18 ++
osaf/services/saf/amf/amfd/ndfsm.cc | 20 ++--
4 files changed, 30 insertions(+), 10 deletions(-)
if th
I have now tested RPM upgrade, and it works. It would have been
surprising if it didn't - that would be a bug in the RPM tool on a very
basic use case.
regards,
Anders Widell
On 10/21/2016 04:50 PM, Mathivanan Naickan Palanivelu wrote:
> Anders,
>
> Were you able to test this? I think this ch
Hi Gary,
You can move the following changes in the beginning of the function
avd_node_up_evh():
+ if (amfnd_svc_db->find(n2d_msg->msg_info.n2d_node_up.node_id) ==
amfnd_svc_db->end()) {
+ // don't process node_up until svc up is received
+ LOG_WA("amfnd svc up
Hi Neel
Ack with comments
Tested that long DN setting during campaign init works again.
The solution for reading this setting results in a lot of redundant code.
Reading of this setting from IMM and updating global variables is done in many
places (I have counted to 5). This is risky and hard
osaf/services/saf/immsv/immnd/ImmModel.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
After a commit of an SMF campaign, the syslog was filled with thousands of log
messages with the text "Delete of PERSISTENT runtime object ...". Since the
syslog is a global log for all applicat
Summary: imm: Convert syslog message to TRACE, to avoid filling up the syslog
[#2136]
Review request for Trac Ticket(s): 2136
Peer Reviewer(s): Hung, Neelakanta, Zoran
Pull request to:
Affected branch(es): opensaf-5.0.x, opensaf-5.1.x, default(5.2)
Development branch: default
---
Summary: amfd: ignore node_up until the mds event amfnd up has been received V2
[#2124]
Review request for Trac Ticket(s): 2124
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): all
Development branch: default
Impacted area Impact y/n
-
osaf/services/saf/amf/amfd/include/node.h | 1 +
osaf/services/saf/amf/amfd/main.cc| 1 +
osaf/services/saf/amf/amfd/mds.cc | 18 ++
osaf/services/saf/amf/amfd/ndfsm.cc | 20 ++--
4 files changed, 30 insertions(+), 10 deletions(-)
if th
osaf/services/saf/amf/amfnd/err.cc | 5 +
1 files changed, 5 insertions(+), 0 deletions(-)
If there is an outstanding healthcheck in progress when a component
is ordered to terminate, then the healthcheck can't be expected
to succeed. In this case, we should not order a cleanup of the compo
Summary: amfnd: ignore healthcheck failure if comp is terminating [#1950]
Review request for Trac Ticket(s): 1950
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): all
Development branch: default
Impacted area Impact y/n
---
Hi Anders,
Reviewed the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Anders Widell anders.wid...@ericsson.com
Sent: Monday, October 24, 2016 6:15PM
To: Hung Nguyen, Neelakanta Reddy, Zoran Milinkov
Hi Praveen
Ack. This comment can be removed.
//Give atleast one try for of Send() and Free() API.
Thanks
Gary
> On 24 Oct. 2016, at 5:46 pm, praveen.malv...@oracle.com wrote:
>
> osaf/services/saf/amf/amfd/imm.cc| 35 +++---
> osaf/services/saf/amf/amfd/include/imm.h | 26 +++-
> osa
Ack (Not tested)
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 25 October 2016 07:54
> To: hans.nordeb...@ericsson.com; Praveen Malviya; Nagendra Kumar;
> minh.c...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 o
Hi Hoang,
With the patch after CPND restart cpnd shm open request is getting failed
please test CPND restart cases.
saCkptCheckpointOpen returned checkpointHandle 626040
222 saCkpt
Hi Gary,
The following changes (line no. 420) are the same as in previous email, please
change:
+ if (amfnd_svc_db->find(n2d_msg->msg_info.n2d_node_up.node_id) ==
amfnd_svc_db->end()) {
+ // don't process node_up until svc up is received
+ LOG_NO("amfnd svc up n
Hi Nagu
I did move it up higher in avd_node_up_evh() as you suggest. But I think we
should leave it after
the headless logic.
Thanks
Gary
> On 25 Oct. 2016, at 5:08 pm, Nagendra Kumar wrote:
>
> Hi Gary,
> The following changes (line no. 420) are the same as in previous email,
> please chan
You mean to store SUSI messages from Amfnd ?
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 25 October 2016 11:44
> To: Nagendra Kumar
> Cc: hans.nordeb...@ericsson.com; Praveen Malviya;
> minh.c...@dektech.com.au; long.hb.ngu...@dektech.com.au;
Hi Nagu
"Hi Gary,
You can move the following changes in the beginning of the function
avd_node_up_evh():
+ if (amfnd_svc_db->find(n2d_msg->msg_info.n2d_node_up.node_id) ==
amfnd_svc_db->end()) {
+ // don't process node_up until svc up is received
+ LOG_WA("amf
Yes Gary. I wanted it to be first check in the function. You see problem with
it?
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 25 October 2016 11:49
> To: Nagendra Kumar
> Cc: hans.nordeb...@ericsson.com; Praveen Malviya;
> minh.c...@dektech.
Dear Mahesh,
Thank you very much for your checking.
It is very strangle that I tested with 2 following case:
- restart nd by kill -9
- restart node by kill -9
Both cases executed well in my local machine.
Would you please tell me the process to reproduce this error?
It is very strangle that ER
Hi Gary,
Ack, code review only/Thanks HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 25 oktober 2016 04:24
To: Hans Nordebäck ; praveen.malv...@oracle.com;
nagendr...@oracle.com; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1
Hi Hoang,
On 10/25/2016 12:10 PM, Vo Minh Hoang wrote:
> Would you please tell me the process to reproduce this error?
I will write standalone application and will share with you .
-AVM
On 10/25/2016 12:10 PM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> Thank you very much for your checking.
> It is
Hi Anders,
Reviewed the patch.
Ack.
/Neel.
On 2016/10/24 04:45 PM, Anders Widell wrote:
> osaf/services/saf/immsv/immnd/ImmModel.cc | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> After a commit of an SMF campaign, the syslog was filled with thousands of log
> messages wit
27 matches
Mail list logo
