Re: [devel] [PATCH 1 of 1] amfd: ignore node_up until the mds event amfnd up has been received [#2124]

2016-10-25 Thread Gary Lee
Hi Nagu That if statement could be anywhere before messages to amfnd are sent. It's just that the headless recovery node counting code can still continue to run as it's not sending anything to amfnd. So I think we can put the new if statement after this? thanks Gary > On 25 Oct. 2016, at 5:3

[devel] [PATCH 0 of 1] Review Request for base: Using TRACE log priority when creation of real-time scheduling policy is not supported [#1923]

2016-10-25 Thread reddy . neelakanta
Summary: base: Using TRACE log priority when real-time scheduling policy is not supported [#1923] Review request for Trac Ticket(s):1923 Peer Reviewer(s): Ramesh, Anders Affected branch(es):5.0.x,5.1.x,default Development branch: default Impacted area Impa

[devel] [PATCH 1 of 1] base: Using TRACE log priority when real-time scheduling policy is not supported [#1923]

2016-10-25 Thread reddy . neelakanta
osaf/libs/core/leap/os_defs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osaf/libs/core/leap/os_defs.c b/osaf/libs/core/leap/os_defs.c --- a/osaf/libs/core/leap/os_defs.c +++ b/osaf/libs/core/leap/os_defs.c @@ -224,7 +224,7 @@ unsigned int ncs_os_task(NCS_OS_TASK *ta

Re: [devel] [PATCH 1 of 1] smf:read imm longdn attribute at campaigninit [#2119]

2016-10-25 Thread Neelakanta Reddy
Hi Lennart, Thanks, for the comment. Open an enhancement ticket, for having an applier towards imm class. /Neel. On 2016/10/24 04:24 PM, Lennart Lund wrote: > Hi Neel > > Ack with comments > > Tested that long DN setting during campaign init works again. > > The solution for reading this setting

[devel] [PATCH 0 of 1] Review Request for imm: Avoid hard coding attributes count in saImmOmAccessorGet_2_04 [#2140]

2016-10-25 Thread Hung Nguyen
Summary: imm: Avoid hard coding attributes count in saImmOmAccessorGet_2_04 [#2140] Review request for Trac Ticket(s): 2140 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.2 Development branch: 5.2 Impacted area Impact y/n -

[devel] [PATCH 1 of 1] imm: Avoid hard coding attributes count in saImmOmAccessorGet_2_04 [#2140]

2016-10-25 Thread Hung Nguyen
tests/immsv/management/test_saImmOmAccessorGet_2.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) Avoid hard coding attributes count in saImmOmAccessorGet_2_04. diff --git a/tests/immsv/management/test_saImmOmAccessorGet_2.c b/tests/immsv/management/test_saImmOmAccess

Re: [devel] [PATCH 1 of 1] amfd: ignore node_up until the mds event amfnd up has been received [#2124]

2016-10-25 Thread Nagendra Kumar
Hi Gary, The node up messages is invalid from Mds point of view and so let's not process the node up message itself. So, keeping the NODE_UP check as first check in the function is better option. Thanks -Nagu > -Original Message- > From: Gary Lee [mailto:gary@dektech.com.au]

[devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) [#2132]

2016-10-25 Thread Hans Nordeback
osaf/libs/core/mds/mds_dt_tipc.c | 374 +- 1 files changed, 203 insertions(+), 171 deletions(-) This first part changes the socket descriptors to non blocking at receive. This to read all incoming messages before returning to the next poll call. diff --git a

[devel] [PATCH 0 of 1] Review Request for mds: Remove use of mutex at TIPC receive (part 1) [#2132]

2016-10-25 Thread Hans Nordeback
Summary: mds: Remove use of mutex at TIPC receive (part 1) Review request for Trac Ticket(s): #2132 Peer Reviewer(s): Mahesh, AndersW Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n -

Re: [devel] [PATCH 1 of 1] imm: Avoid hard coding attributes count in saImmOmAccessorGet_2_04 [#2140]

2016-10-25 Thread Zoran Milinkovic
Hi Hung, Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 25 oktober 2016 12:54 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] imm: Avoid hard coding attri

Re: [devel] [PATCH 1 of 1] base: Using TRACE log priority when real-time scheduling policy is not supported [#1923]

2016-10-25 Thread Anders Widell
Ack. regards, Anders Widell On 10/25/2016 11:30 AM, reddy.neelaka...@oracle.com wrote: > osaf/libs/core/leap/os_defs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/osaf/libs/core/leap/os_defs.c b/osaf/libs/core/leap/os_defs.c > --- a/osaf/libs/core/leap/os_d

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-25 Thread A V Mahesh
Hi Hoang, The attached `test_#2108_app.c` application will generate cpnd shm open request is getting failed case #gcc test_#2108_app.c -o checkpoint -lSaCkpt -AVM On 10/25/2016 12:23 PM, A V Mahesh wrote: Hi Hoang, On 10/25/2016 12:10 PM, Vo Minh Hoang wrote: Would you please tell me the

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-25 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your help. Compared to your test app I found my test stop too soon. After reboot I just check shm existence, did not check to open again. I will send fix patch soon after carefully test it again. Thank you and best regards, Hoang -Original Message- F

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-25 Thread A V Mahesh
Hi Hoan, What I tested is a simple default cpsv `small format shm` ( Short-DN) functionality, this `big format shm` (LONG-DN) fix has side-effect/implication on existing functionality and these issue will become more complex to handle bugs, so please test all case as follows with new patch a