Re: [devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process V3 [#2091]

2016-10-27 Thread Hans Nordeback
Hi Anders, fine, I'll update, see one comment below. /Thanks HansN On 10/26/2016 02:21 PM, Anders Widell wrote: > Ack with comments. > > regards, > > Anders Widell > > > On 10/22/2016 02:54 PM, Hans Nordeback wrote: >> osaf/libs/core/common/daemon.c | 26 >> osaf/services/infrastructure/dtm

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-27 Thread Vo Minh Hoang
Dear Mahesh, I tested with cases: - Old active with new standby - Old standby with new active Each case, create checkpoint, create section, write and read section, close and unlink. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, Oc

Re: [devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process V3 [#2091]

2016-10-27 Thread Hans Nordebäck
One more comment, in daemon.c we can move create_fifo before __create_pid, this will close the raise window and then its needed to only check EINTR at fifo open. /Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 27 oktober 2016 09:17 T

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-27 Thread A V Mahesh
Hi Hoang, ACK form me. Function change looks less and code resignations looks much, to make review easy next time on-words please split the function change & code resignations in to different patches ( 1 of 2 & 2 of 2). Not Tested , in-service upgrade & log DN cases -AVM On 10/27/2016 12:4

Re: [devel] [PATCH 1 of 1] smf:read imm longdn attribute at campaigninit [#2119]

2016-10-27 Thread Rafael Odzakow
Questions below. On 10/21/2016 01:31 PM, reddy.neelaka...@oracle.com wrote: > osaf/services/saf/smfsv/smfd/SmfCampaignInit.cc | 17 +++-- > 1 files changed, 15 insertions(+), 2 deletions(-) > > > diff --git a/osaf/services/saf/smfsv/smfd/SmfCampaignInit.cc > b/osaf/services/saf/sm

[devel] [PATCH 1 of 3] base: Use inotify to improve response time for transport monitor process V4 [#2091]

2016-10-27 Thread Hans Nordeback
osaf/libs/core/cplusplus/base/Makefile.am|2 + osaf/libs/core/cplusplus/base/file_notify.cc | 190 +++ osaf/libs/core/cplusplus/base/file_notify.h | 102 ++ 3 files changed, 294 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/cplusplus/bas

[devel] [PATCH 0 of 3] Review Request for dtm: Use inotify to improve response time for transport monitor process V4 [#2091]

2016-10-27 Thread Hans Nordeback
Summary: dtm: Use inotify to improve response time for transport monitor process V4 Review request for Trac Ticket(s): #2091 Peer Reviewer(s): Ramesh, Mahesh, AndersW Pull request to: Affected branch(es): default Development branch: default Impacted area Im

[devel] [PATCH 2 of 3] base: Unit tests for FileNotify V4 [#2091]

2016-10-27 Thread Hans Nordeback
osaf/libs/core/cplusplus/base/tests/Makefile.am | 7 +- osaf/libs/core/cplusplus/base/tests/file_notify_test.cc | 83 + 2 files changed, 88 insertions(+), 2 deletions(-) diff --git a/osaf/libs/core/cplusplus/base/tests/Makefile.am b/osaf/libs/core/cplusplus/base/tests

[devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process V4 [#2091]

2016-10-27 Thread Hans Nordeback
osaf/libs/core/common/daemon.c | 38 ++ osaf/services/infrastructure/dtms/transport/tests/Makefile.am | 3 +- osaf/services/infrastructure/dtms/transport/tests/transport_monitor_test.cc | 4 +- osaf/services/infrastructure/dtms

[devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) V2 [#2132]

2016-10-27 Thread Hans Nordeback
osaf/libs/core/mds/mds_dt_tipc.c | 374 +- 1 files changed, 203 insertions(+), 171 deletions(-) This first part changes the socket descriptors to non blocking at receive. This to read all incoming messages before returning to the next poll call. diff --git a

[devel] [PATCH 0 of 1] Review Request for mds: Remove use of mutex at TIPC receive (part 1) V2 [#2132]

2016-10-27 Thread Hans Nordeback
Summary: mds: Remove use of mutex at TIPC receive (part 1) V2 Review request for Trac Ticket(s): #2132 Peer Reviewer(s): Mahesh, AndersW Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n --

Re: [devel] [PATCH 0 of 3] Review Request for dtm: Use inotify to improve response time for transport monitor process V4 [#2091]

2016-10-27 Thread ramesh betham
Hi Hans, Just FYI, I will be reviewing these V4 patches and shall provide my review comments next week. Thanks and Regards, Ramesh. On 10/27/2016 8:55 PM, Hans Nordeback wrote: > Summary: dtm: Use inotify to improve response time for transport monitor > process V4 > Review request for Trac Tic

Re: [devel] [PATCH 0 of 3] Review Request for dtm: Use inotify to improve response time for transport monitor process V4 [#2091]

2016-10-27 Thread Hans Nordebäck
Hi Ramesh, Thanks, for info, I added a close of the fifo fd in daemon_exit() after I sent out the V4, so that close is missing in V4. /BR HansN -Original Message- From: ramesh betham [mailto:ramesh.bet...@oracle.com] Sent: den 28 oktober 2016 07:10 To: Hans Nordebäck Cc: Anders Widell ;