Hi!
Yes agreed, using this mechanism also for trace is a logical next step.
It should be fairly easy to implement once this MDS logging mechanism is
fully in place.
regards,
Anders Widell
On 11/03/2016 06:14 AM, A V Mahesh wrote:
> Hi Anders Widell,
>
> >>Using a standardized format means tha
Ack with very minor comments inline.
Regards,
Ramesh.
On 10/27/2016 8:55 PM, Hans Nordeback wrote:
> osaf/libs/core/cplusplus/base/Makefile.am|2 +
> osaf/libs/core/cplusplus/base/file_notify.cc | 190
> +++
> osaf/libs/core/cplusplus/base/file_notify.h | 1
Ack.
Thanks,
Ramesh.
On 10/27/2016 8:55 PM, Hans Nordeback wrote:
> osaf/libs/core/cplusplus/base/tests/Makefile.am | 7 +-
> osaf/libs/core/cplusplus/base/tests/file_notify_test.cc | 83
> +
> 2 files changed, 88 insertions(+), 2 deletions(-)
>
>
> diff --git a/os
Summary: amfd: add support of saAmfSUAssignedSIs [#905]
Review request for Trac Ticket(s): #905
Peer Reviewer(s): Amf Dev
Pull request to: <>
Affected branch(es): Default
Development branch: Default
Impacted area Impact y/n
D
osaf/services/saf/amf/amfd/imm.cc| 63
osaf/services/saf/amf/amfd/include/imm.h | 7 +++
osaf/services/saf/amf/amfd/su.cc | 31 ---
3 files changed, 95 insertions(+), 6 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b
osaf/libs/agents/saf/imma/Makefile.am | 24 ++--
osaf/libs/agents/saf/imma/imma_db.c | 0
osaf/libs/agents/saf/imma/imma_init.c | 0
osaf/libs/agents/saf/imma/imma_mds.c| 0
osaf/libs/agents/saf/imma/imma_oi_api.c | 0
osaf/libs/agents/saf/imma/imma_om_
Summary: imm: Compile the IMM library using the C++ compiler [#2142]
Review request for Trac Ticket(s): 2142
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.2
Development branch: 5.2
Impacted area Impact y/n
-
osaf/libs/agents/saf/imma/imma_db.cc |7 +-
osaf/libs/agents/saf/imma/imma_init.cc |4 +-
osaf/libs/agents/saf/imma/imma_mds.cc|4 +-
osaf/libs/agents/saf/imma/imma_oi_api.cc | 34 +++---
osaf/libs/agents/saf/imma/imma_om_api.cc | 144 +++---
osaf/l
osaf/libs/agents/saf/imma/imma_cb.h | 2 +-
osaf/libs/agents/saf/imma/imma_db.cc | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.cc | 2 +-
osaf/libs/agents/saf/imma/imma_proc.cc | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
Fix "comparison between signed and unsigned i
osaf/libs/agents/saf/imma/imma_db.cc | 3 +--
osaf/libs/agents/saf/imma/imma_oi_api.cc | 7 +++
osaf/libs/agents/saf/imma/imma_om_api.cc | 24 +---
osaf/libs/agents/saf/imma/imma_proc.cc | 6 --
4 files changed, 21 insertions(+), 19 deletions(-)
Fix "cros
osaf/libs/agents/saf/imma/imma_init.cc | 1 -
osaf/libs/agents/saf/imma/imma_om_api.cc | 1 -
osaf/libs/core/mds/include/mds_dl_api.h | 9 +
osaf/libs/saf/libSaImm/Makefile.am | 4 ++--
osaf/libs/saf/libSaImm/libSaImmOm.map| 14 --
5 files changed, 19 inse
Summary: mds: Make the MdsLog implementation lock-free [#2127]
Review request for Trac Ticket(s): 2127
Peer Reviewer(s): Mahesh, Ramesh
Pull request to:
Affected branch(es): default(5.2)
Development branch: default
Impacted area Impact y/n
--
osaf/libs/core/cplusplus/base/unix_client_socket.cc | 28 ---
osaf/libs/core/cplusplus/base/unix_client_socket.h | 2 +-
osaf/libs/core/cplusplus/base/unix_server_socket.cc | 19 +--
osaf/libs/core/cplusplus/base/unix_server_socket.h | 4 +-
osaf/libs/core/cplusplus/base/unix_s
osaf/libs/core/mds/mds_log.cc | 42 --
1 files changed, 16 insertions(+), 26 deletions(-)
Use the va_list version of Buffer::Write() to avoid the need for formatting the
message into a temporary buffer.
diff --git a/osaf/libs/core/mds/mds_log.cc b/osaf/l
osaf/libs/core/mds/include/mds_log.h | 10
osaf/libs/core/mds/mds_log.cc| 37 +++
2 files changed, 13 insertions(+), 34 deletions(-)
Remove the mutex from the MdsLog class, by allocating a temporary Buffer
instance on the stack and relying on th
osaf/libs/core/cplusplus/base/log_message.h | 56 +
1 files changed, 56 insertions(+), 0 deletions(-)
Make it possible to send a format string and a va_list to Buffer::Write, so that
it can be used more efficiently in a printf-style function.
diff --git a/osaf/libs/
osaf/libs/core/cplusplus/base/buffer.h | 26 +-
osaf/libs/core/cplusplus/base/log_message.cc| 106 -
osaf/libs/core/cplusplus/base/log_message.h | 126 +++-
osaf/libs/core/cplusplus/base/tests/log_message_test.cc | 14 +-
osaf/
Ack tested.
-AVM
On 11/3/2016 1:58 PM, Anders Widell wrote:
> Hi!
>
> Yes agreed, using this mechanism also for trace is a logical next
> step. It should be fairly easy to implement once this MDS logging
> mechanism is fully in place.
>
> regards,
>
> Anders Widell
>
> On 11/03/2016 06:14 AM,
Summary: imm: Fix external linkage in OI library [#2167]
Review request for Trac Ticket(s): 2167
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.0, 5.1, 5.2
Development branch: 5.2
Impacted area Impact y/n
---
osaf/libs/agents/saf/imma/imma_oi_api.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Fix external linkage in OI library.
diff --git a/osaf/libs/agents/saf/imma/imma_oi_api.c
b/osaf/libs/agents/saf/imma/imma_oi_api.c
--- a/osaf/libs/agents/saf/imma/imma_oi_api.c
+++ b/osaf/libs/age
20 matches
Mail list logo
