src/amf/amfd/comp.cc | 15 +++
src/amf/amfnd/compdb.cc| 1 +
src/amf/common/amf_defs.h | 1 +
src/amf/config/amf_classes.xml | 1 +
4 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/src/amf/amfd/comp.cc b/src/amf/amfd/comp.cc
--- a/src/amf/a
Summary: amf: change saAmfCompCmdEnv attribute to writable [#2255]
Review request for Trac Ticket(s): #2255
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
-
Summary: cpd: to correct failover behavior of cpsv [#1765]
Review request for Trac Ticket(s): 1765
Peer Reviewer(s): mahesh.va...@oracle.com; zoran.milinko...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default
src/ckpt/ckptd/cpd_db.c | 15 +++
src/ckpt/ckptd/cpd_evt.c| 12
src/ckpt/ckptd/cpd_proc.c | 18 --
src/ckpt/ckptnd/cpnd_evt.c | 3 ++-
src/ckpt/ckptnd/cpnd_proc.c | 12 +---
5 files changed, 50 insertions(+), 10 deletions(-)
probl
Ack.
regards,
Anders Widell
On 01/19/2017 07:24 AM, Hung Nguyen wrote:
> src/imm/Makefile.am | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> Add imm_common to LIBADD list of libSaImmOi.
>
> diff --git a/src/imm/Makefile.am b/src/imm/Makefile.am
> --- a/src/imm/Makefile.am
> +
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 19 januari 2017 07:25
To: Zoran Milinkovic ;
reddy.neelaka...@oracle.com; Anders Widell
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Add imm
Hi Hung,
Reviewed the patch, Ack.
/Neel.
On 2017/01/19 11:54 AM, Hung Nguyen wrote:
> src/imm/Makefile.am | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> Add imm_common to LIBADD list of libSaImmOi.
>
> diff --git a/src/imm/Makefile.am b/src/imm/Makefile.am
> --- a/src/imm/Ma
Ack, code review only.
Thanks,
Praveen
On 18-Jan-17 9:50 AM, Minh Hon Chau wrote:
> src/amf/amfd/role.cc |2 +-
> src/amf/amfd/sg.h |1 -
> src/amf/amfd/sg_2n_fsm.cc | 142
>
> src/amf/amfd/sg_npm_fsm.cc | 138 ++
Ack. No more comments on top of Anders comments.
Thanks,
Ramesh.
On 1/10/2017 8:07 PM, Anders Widell wrote:
> Ack with comments inline, marked AndersW>
>
> regards,
>
> Anders Widell
>
>
> On 01/04/2017 03:28 PM, Zoran Milinkovic wrote:
>> src/base/sysf_tmr.c | 9 -
>> 1 files changed
Summary: imm: Remove unused variables from saImmOmClassCreate_2() [#2271]
Review request for Trac Ticket(s): 2271
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.2
Development branch: 5.2
Impacted area Impact y/n
src/imm/agent/imma_om_api.cc | 147 --
1 files changed, 69 insertions(+), 78 deletions(-)
Remove unused variables from saImmOmClassCreate_2().
diff --git a/src/imm/agent/imma_om_api.cc b/src/imm/agent/imma_om_api.cc
--- a/src/imm/agent/imma_om_api.cc
+++
src/imm/immnd/ImmModel.cc | 58 +-
1 files changed, 32 insertions(+), 26 deletions(-)
The mismatch only happens in ::ccbObjectCreate(), ::ccbObjectModify(),
::deleteObject().
The changes in other functions are to make sure that we handle
sLastContin
Summary: imm: Fix the mismatch when resetting sLastContinuationId [#2272]
Review request for Trac Ticket(s): 2272
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.0, 5.1, 5.2
Development branch: 5.2
Impacted area Impact y/n
--
Hi,
I am not able to correlate this patch with the problem description of
#2248.
I see the changes mentioned in the patch are not required. Probably need
to do more evaluation why the test hangs forever for
SysfTmrTest.TestIntervalTimer. Any supporting logs?
Thanks,
Ramesh.
On 1/10/2017 6:48
Summary: log: implement SaLogFilterSetCallbackT and version handling V3 [#2146]
Review request for Trac Ticket(s): #2146
Peer Reviewer(s): Vu, Lennart, Mahesh
Pull request to: Vu
Affected branch(es): default
Development branch: default
Impacted area Impact y/
src/log/agent/lga.h |3 +
src/log/agent/lga_mds.c | 70 +
src/log/agent/lga_util.c | 63 -
src/log/apitest/logtest.c |2 +-
src/log/apitest/logtestfr.c |2 +-
src/log/
src/log/Makefile.am |2 +
src/log/common/lgsv_defs.h |4 +
src/log/common/lgsv_msg.h|2 +-
src/log/logd/lgs_cb.h|1 +
src/log/logd/lgs_evt.cc | 92 -
src/log/logd/lgs_mbcsv.cc| 176 ++
sr
src/log/agent/lga_api.c | 55 --
src/log/apitest/tet_saLogFilterSetCallbackT.c | 53 ++
src/log/apitest/tet_saLogInitialize.c | 23 +++
3 files changed, 117 insertions(+), 14 deletions(-)
Fix checking versio
Hi Ramesh,
Seems that there is some issue with the timer.
I'm not getting working the timer correctly all the time.
I was talking with Anders W. this week to use conditional variables to sync
timer thread with other threads.
To reproduce the timer problem, just simply run the unit test for timer
Ack with minor comment marked AndersW>
regards,
Anders Widell
On 01/13/2017 10:40 AM, Hans Nordeback wrote:
> src/amf/amfd/ckpt_dec.cc | 2 +
> src/amf/amfd/clm.cc | 2 +
> src/amf/amfd/csi.cc | 7 -
> src/amf/amfd/node.cc
Ack.
regards,
Anders Widell
On 01/13/2017 02:16 PM, Hans Nordeback wrote:
> tools/devel/dot/trace2dot | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/tools/devel/dot/trace2dot b/tools/devel/dot/trace2dot
> --- a/tools/devel/dot/trace2dot
> +++ b/tools/devel/d
Thanks Anders, I'll update the patch before pushing. /BR HansN
-Original Message-
From: Anders Widell
Sent: den 19 januari 2017 15:15
To: Hans Nordebäck ; ramesh.bet...@oracle.com;
nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] base: Improve TRA
Hi Ramesh and Nagendra,
Have you had any time to look at this patch? /Thanks HansN
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 19 januari 2017 15:27
To: Anders Widell ; ramesh.bet...@oracle.com;
nagendr...@oracle.com
Cc: opensaf-devel@lists.sou
Summary: amfd: use more appropriate log severity levels in si_swap_validate()
[#1897]
Review request for Trac Ticket(s): 1897
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): all
Development branch: default
Impacted area Impact y/n
--
src/amf/amfd/si.cc | 24
1 files changed, 12 insertions(+), 12 deletions(-)
First 5 changes below revert to behaviour introduced in changeset 1f7da38c884b.
They were changed recently by #1294.
Other changes are:
* if TRY_AGAIN is returned, then the log level should be
Ack.
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 20 January 2017 06:36
> To: Nagendra Kumar; long.hb.ngu...@dektech.com.au;
> hans.nordeb...@ericsson.com; minh.c...@dektech.com.au; praveen
> malviya; gary@dektech.com.au
> Cc: opensaf-dev
Hi Hoang ,
Can you please help me understating the issue , based on Reproduce step,
I am not able to relate the fix (patch) with the original problem.
On 1/20/2017 10:04 AM, Vo Minh Hoang wrote:
> Reproduce steps:
> - in SC1 open a checkpoint (non col)
> - set retention value to big: 9
> - re
27 matches
Mail list logo
