On 11-Apr-17 9:03 PM, Anders Widell wrote:
> A question:
>
> I noticed that clms_send_is_member_info() is called twice from
> clms_imm_node_unlock(), but you only modified the first call (the one
> without PLM). Shouldn't the PLM case also be updated? Is a similar
> change also applicable in
Hi Hoang,
On 2/10/2017 3:09 PM, Vo Minh Hoang wrote:
> If cpnd is temporary down only, we don't need clean up anything.
> If cpnd is permanently down, the bad effect of this proposal is that replica
> is not clean up. But if cpnd permanently down, we have to reboot node for
> recovering so I think
Dear Mahesh,
Sorry when it takes time to recall some long lost information.
Bellowing is the reproduce steps in newest source code:
- create some non-collocated checkpoints in SC-1
- make failover occur by pkill -9 amfd
- do that again 4 time with active SC
- check /run/shm found that all replica
Summary: log: refactor log agent [#2412]
Review request for Ticket(s): 2412
Peer Reviewer(s): Lennart, Canh, Mahesh
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2412
Private repository: git://git.code.sf.net/u/winhvu/review
From: Hoa Le
Problem:
- There are some unsafe memory accesses which may cause segfault in
avnd_comptype_delete() function.
Fix:
- Check if a pointer is valid before accessing it.
- Minor update in avnd_comptype_create() function to avoid unnecessary
function call to avnd_comptype_delete().
---
From: Hoa Le
Summary: amfnd: Fix illegal memory access in avnd_comptype_delete [#2424]
Review request for Ticket(s): 2424
Peer Reviewer(s): AMF devs
Pull request to: AMF maints
Affected branch(es): develop, release
Development branch: ticket-2424
Private repository: git://git.code.sf.net/u/xhoale
The $piddir variable (containing path to amf_demo comp's pid file)
is missed to be defined in amf_demo_script.
This could lead to the amf_demo process not getting truely killed
in some cases when cleanup is called (e.g when invoking
saAmfComponentErrorReport()), leaving the process unmanaged by AM
Summary: samples: fix $piddir undefined in amf_demo_script [#2410]
Review request for Ticket(s): 2410
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): develop, release
Development branch: ticket-2410
Private repository: git://git.code.sf.net/u/nguyenluu/review
Ack. Re-based version of the patch attached.
regards,
Anders Widell
On 04/03/2017 10:09 AM, praveen.malv...@oracle.com wrote:
src/clm/clmd/clms_evt.c | 2 +-
src/clm/clmd/clms_imm.c | 11 +--
src/clm/clmd/clms_mbcsv.c | 2 +-
src/clm/clmd/clms_util.c | 16 ++---
Hi Hoa
Ack (review only). One minor comment, I wonder if we can simplify
avnd_comptype_delete() a bit by reducing the amount of ‘nesting’.
Since compt->yyy should never be null after your change in
avnd_comptype_create(), perhaps we can do add asserts instead of adding the ‘if
(compt->yyy != n
Ack, code review only.
Thanks,
praveen
On 12-Apr-17 6:06 PM, Nguyen Luu wrote:
> The $piddir variable (containing path to amf_demo comp's pid file)
> is missed to be defined in amf_demo_script.
>
> This could lead to the amf_demo process not getting truely killed
> in some cases when cleanup is
ack, code review only/Thanks HansN
On 04/12/2017 02:36 PM, Nguyen Luu wrote:
> The $piddir variable (containing path to amf_demo comp's pid file)
> is missed to be defined in amf_demo_script.
>
> This could lead to the amf_demo process not getting truely killed
> in some cases when cleanup is cal
Summary: log: refactor handling IMM in log service - 1st inc [#2149]
Review request for Ticket(s): 2149
Peer Reviewer(s): All OpenSAF dev
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2149
Private repository: git://git.code.sf
Here is the first increment - create C++ IMM wrapper for IMM API.
Aim to create simple and easy interfaces for using IMM.
---
Makefile.am| 1 +
src/immwrp/Makefile| 22 ++
src/immwrp/Makefile.am
14 matches
Mail list logo
