[devel] [PATCH 1/1] imm: Add more details to no dangling CcbErrorString [#2433]

2017-04-20 Thread Hung Nguyen
Add more details to no dangling CcbErrorString. --- src/imm/immnd/ImmModel.cc | 50 +++ 1 file changed, 50 insertions(+) diff --git a/src/imm/immnd/ImmModel.cc b/src/imm/immnd/ImmModel.cc index 35c8a31..7afce0f 100644 --- a/src/imm/immnd/ImmModel.cc +++

[devel] [PATCH 0/1] Review Request for imm: Add more details to no dangling CcbErrorString [#2433]

2017-04-20 Thread Hung Nguyen
Summary: imm: Add more details to no dangling CcbErrorString [#2433] Review request for Ticket(s): 2433 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): develop Development branch: ticket-2433 Base revision: bfebede5783121fc363f63536bbb89ba3355152e Personal repository: git://git

Re: [devel] [PATCH 1/1] amfnd: Fix illegal memory access in avnd_comptype_delete [#2424]

2017-04-20 Thread Nagendra Kumar
Hi Hoa Le,     I could see that there is NULL check below assert() you had added. So, let it be also a NULL check and if this is NULL, you can throw some log. As ticket mention that Amfnd has crashed accessing NULL pointer, if you add assert, it will crash anyway(in

Re: [devel] [PATCH 1/1] amfnd: Fix illegal memory access in avnd_comptype_delete [#2424]

2017-04-20 Thread Hoa Le
Hi, Thanks for your comments, 1. As pointed out by Gary, there is a NULL check at the beginning of avnd_comptype_delete() function, so it is still safe if we pass a NULL comptype to this function when avnd_comptype_create() fails. /static void avnd_comptype_delete(amf_comp_type_t *compt) {// /

[devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

2017-04-20 Thread Canh Van Truong
The patch add dest_names in checkpointing at open stream request. --- src/log/logd/lgs_evt.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc index 6972efe55..fcc02de63 100644 --- a/src/log/logd/lgs_evt.cc +++ b/src/log/logd/lgs_evt.cc @@ -86

[devel] [PATCH 0/1] Review Request for log: fix checkpoint dest_names in open stream request [#2434]

2017-04-20 Thread Canh Van Truong
Summary: log: fix checkpoint dest_names in open stream request [#2434] Review request for Ticket(s): 2434 Peer Reviewer(s): Vu, Lennart, Mahesh Pull request to: Vu Affected branch(es): develop, 5.2.x Development branch: ticket-2434 Base revision: 495c3395bc015c2b01fb7d1ba3f04362f92990ff Personal re

[devel] [PATCH 1/1] smf: cli-command does not wait for nodes to start [#1969]

2017-04-20 Thread Rafael Odzakow
While doing the wrapup of a one-step upgrade with reboot the other controller takes extra time to come back up. Now when we have a CLI command in the campaign doing a operation on that missing controller the campaign will fail. The reason is that there is no timer to wait for node up. This patch us

[devel] [PATCH 0/1] Review Request for smf: cli-command does not wait for nodes to start [#1969]

2017-04-20 Thread Rafael Odzakow
Summary: smf: cli-command does not wait for nodes to start [#1969] Review request for Ticket(s): 1969 Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE *** Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-1969

Re: [devel] [PATCH 1/1] rde: save a role for active and standby nodes in peer info request [#2423]

2017-04-20 Thread Zoran Milinkovic
Hi Anders, I'll add your comments when I push the code. Thanks, Zoran -Original Message- From: Anders Widell Sent: den 18 april 2017 16:06 To: Zoran Milinkovic ; ramesh.bet...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] rde: save a role for active

[devel] [PATCH 1/1] smf: updated the imm API vesrion to latest supported [#2431]

2017-04-20 Thread Neelakanta Reddy
--- src/smf/smfd/SmfCampaignThread.cc | 2 +- src/smf/smfd/SmfExecControlHdl.h | 2 +- src/smf/smfd/SmfImmApplierHdl.h| 2 +- src/smf/smfd/SmfImmOperation.cc| 15 +-- src/smf/smfd/SmfProcedureThread.cc | 2 +- src/smf/smfd/SmfUpgradeCampaign.cc | 2 ++ src/smf/smfd/SmfU

[devel] [PATCH 0/1] Review Request for smf: updated the imm API vesrion to latest supported [#2431]

2017-04-20 Thread Neelakanta Reddy
Summary: smf: updated the imm API vesrion to latest supported [#2431] Review request for Ticket(s): 2431 Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE *** Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release, 5.2.x Development b