[devel] [PATCH 0/1] Review Request for base: Atomically create pid file from temporary pid file V2 [#2432]

2017-05-24 Thread Minh Chau
Summary: base: Atomically create pid file from temporary pid file V2 [#2432] Review request for Ticket(s): 2432 Peer Reviewer(s): AndersW, HansN Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2432 Base revision:

[devel] [PATCH 1/1] base: Atomically create pid file from temporary pid file V2 [#2432]

2017-05-24 Thread Minh Chau
At startup, osaftransportd waits for osafdtmd.pid file creation and then reads dtm pid. If osafdtmd.pid has not been completedly created but osaftransportd still receives IN_CREATE, osaftransported will fail to read pid of dtmd. That results in a node reboot with a reason as "osafdtmd failed to

[devel] [PATCH 1/1] log: fix log agent does not use client version when recovery [#2457]

2017-05-24 Thread Canh Van Truong
When log agent recover the client, it uses the highest version that log agent supported to re-intialize client. It should use the client version to re-initialize client. --- src/log/agent/lga_state.cc | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git

[devel] [PATCH 0/1] Review Request for log: fix log agent does not use client version when recovery [#2457]

2017-05-24 Thread Canh Van Truong
Summary: log: fix log agent does not use client version when recovery [#2457] Review request for Ticket(s): 2457 Peer Reviewer(s): Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): develop, release Development branch: ticket-2457 Base revision: fbf293d25e51f8bd4f8c1922c0dcd188a522d162

Re: [devel] [PATCH 1/1] smf: try to wait for opensafd status before executing reboot [#2464]

2017-05-24 Thread Lennart Lund
Hi Rafael Ack. See comment tagged [Lennart] Thanks Lennart > -Original Message- > From: Rafael Odzakow > Sent: den 19 maj 2017 14:17 > To: Lennart Lund ; > reddy.neelaka...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net; Rafael Odzakow >

Re: [devel] [PATCH 1/1] amfd: only increment su_cnt_admin_oper for non-opensaf SUs [#2466]

2017-05-24 Thread Hans Nordebäck
Ack, code review only/Thanks HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 24 maj 2017 02:52 To: praveen malviya ; Hans Nordebäck ; Minh Hon Chau ;