Re: [devel] [PATCH 3/3] amfnd: Refactor AVND_COMP for simpler cmd argument handling V2 [#1945]

Hi Praveen, The intention with V2 was to correct the case when a space is needed in the argument, but as you say it is not backward compatible. V1 of this patch is backward compatible, I'll put it back and send it out for a new review. /Thanks HansN On 06/13/2017 08:53 AM, praveen malviya

Re: [devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

Hi Praveen, good catch, I'll update. /Thanks HansN On 06/13/2017 08:53 AM, praveen malviya wrote: Hi Hans, One comment on this patch inline with [Praveen]. Thanks, Praveen On 18-May-17 3:32 PM, Hans Nordeback wrote: --- src/amf/amfnd/avnd_comp.h | 134 ++--

[devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

--- src/amf/amfnd/avnd_comp.h | 134 ++ src/amf/amfnd/avnd_err.h | 4 +- src/amf/amfnd/avnd_hc.h | 2 +- src/amf/amfnd/avnd_proc.h | 10 ++-- src/amf/amfnd/avnd_util.h | 2 +- src/amf/amfnd/clc.cc | 125

[devel] [PATCH 3/3] amfnd: Refactor AVND_COMP for simpler cmd argument handling V3 [#1945]

--- src/amf/amfnd/avnd_comp.h | 77 --- src/amf/amfnd/avnd_err.h | 1 + src/amf/amfnd/avnd_hc.h | 1 + src/amf/amfnd/avnd_proc.h | 1 + src/amf/amfnd/avnd_su.h | 1 + src/amf/amfnd/avnd_tmr.h | 7 +-- src/amf/amfnd/avnd_util.h | 1 + src/amf/amfnd/cam

[devel] [PATCH 0/3] Review Request for amfnd: Refactor AVND_COMP for simpler cmd argument handling V3 [#1945]

Summary: amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945] Review request for Ticket(s): 1945 Peer Reviewer(s): Praveen, Gary, Nagu Pull request to: Affected branch(es): develop Development branch: ticket-1945 Base revision: db1965d634eac2f375f455b7b7d3e9f70ff0c47c Perso

[devel] [PATCH 2/3] amfnd: Refactor AVND_SU to class and comp_list to std::vector [#1945]

--- src/amf/amfnd/avnd_comp.h | 16 +--- src/amf/amfnd/avnd_err.h | 6 +- src/amf/amfnd/avnd_su.h | 119 -- src/amf/amfnd/avnd_tmr.h | 10 +-- src/amf/amfnd/avnd_util.h | 3 + src/amf/amfnd/clc.cc | 7 +- src/amf/amfnd/comp.cc | 4 +- src/amf/amfnd/co

[devel] [PATCH 0/1] Review Request for pyosaf: Ensure compatibility with Python 3 [#2492]

Summary: pyosaf: Ensure compatibility with Python 3 [#2492] Review request for Ticket(s): 2492 Peer Reviewer(s): Srikanth, Hans Pull request to: Affected branch(es): develop Development branch: ticket-2492 Base revision: db1965d634eac2f375f455b7b7d3e9f70ff0c47c Personal repository: git://git.code.

[devel] [PATCH 1/1] pyosaf: Ensure compatibility with Python 3 [#2492]

Ensure compatibility with Python 3 by running the Python source code files through the Automated Python 2 to 3 code translation tool "2to3". For more information about this tool, see: https://docs.python.org/3/library/2to3.html --- python/pyosaf/saEnumConst.py | 6 +++--- python/pyos

Re: [devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

Ack for the series. Thanks PRaveen On 13-Jun-17 4:54 PM, Hans Nordeback wrote: --- src/amf/amfnd/avnd_comp.h | 134 ++ src/amf/amfnd/avnd_err.h | 4 +- src/amf/amfnd/avnd_hc.h | 2 +- src/amf/amfnd/avnd_proc.h | 10 ++-- src/amf/amfnd/a