Ack with comments, marked AndersW> in the code below.
A general comment is that this solution only works with IPv4, not with
IPv6 or TIPC. It might also have problems with IPv4 if the nodes have
multiple network interfaces, since you let the kernel select which
interface to use. However since
Hi Canh,
I have not had time to do any proper review yet but I saw that you have not
named the version constant according to Google style guide
Thanks
Lennart
> -Original Message-
> From: minh chau [mailto:minh.c...@dektech.com.au]
> Sent: den 27 september 2017 06:40
> To: Canh Van Truo
Summary: clm: Make the cluster reset admin op safe V3 [#2451]
Review request for Ticket(s): 2451
Peer Reviewer(s): AndersW, Praveen
Pull request to:
Affected branch(es): develop
Development branch: ticket-2451
Base revision: ea24f77bcb58fbfd7ba430bb46143b9f1aaa5110
Personal repository: git://git.c
---
00-README.conf | 10 +-
src/base/osaf_utility.c | 44
src/base/osaf_utility.h | 5 +
src/clm/clmnd/main.c| 1 +
src/nid/nodeinit.cc | 2 ++
5 files changed, 61 insertions(+), 1 deletion(-)
diff --git a/00-README.conf
Hi Anders,
thanks I'll update, regarding the -lgcov it should not be included, just
the --coverage should be necessary, it is according to gcc
documentation a synonym for -fprofile-arcs, -ftest-coverage when
compiling and -lgcov when linking.
/Regards HansN
On 09/27/2017 12:03 PM, Anders
Hi Anders,
Regarding disabling the gcov dump thread, the thread is only created if opensaf
is configured with --enable-gcov and the thread creation is guarded with ifdef
ENABLE_GCOV.
/Regards Hans
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den
Hi Ravi,
ack + legacy tests run.
Just a minor comment before pushing the patch
if (find_instantiable_same_rank_su(i_su))
needs to change to:
if (sg->find_instantiable_same_rank_su(i_su))
Thanks,
Minh
On 26/09/17 14:01, Ravi Sekhar Reddy Konda wrote:
Hi Minh,
Addresse
