Re: [devel] [PATCH 0/1] Review Request for smf: fix numberic attribute types not accept boolean values [#2902]

Hi Vu STOP! I have done some more investigations around this and it seems as if this fix shall not be done at all! I have looked in the specifications (AIS and PR) and cannot find anything saying that Booleans should be handled according to this ticket. I have also checked old code before #1398

Re: [devel] [PATCH 0/1] Review Request for smf: fix numberic attribute types not accept boolean values [#2902]

Hi Lennart, Just want to make clear that this kind of ridiculous bug did not exist before introducing #1398. It used to work perfectly before that. Regards, Vu > -Original Message- > From: Lennart Lund > Sent: Tuesday, July 31, 2018 3:04 PM > To: Vu Minh Nguyen ; Gary Lee > > Cc: opens

Re: [devel] [PATCH 1/1] amfd: Check IMM status before calling saImmOiDispatch [#2885]

Hi Hans, Vu created https://sourceforge.net/p/opensaf/tickets/2906/ Thanks, Minh On 30/07/18 23:37, Hans Nordeback wrote: > Hi Minh, > > I noticed this ticket is set as fixed but one question. Looking at the > backtrace in the ticket, it seems > > that the imma_cb struct cb_lock mutex is creat

Re: [devel] [PATCH 1/1] amfd: put sync jobs into queue if IMM is busy [#2863]

Hi Gary, You can remove all const_cast's in functions where the const parameter has been removed, e.g. AVD_CL_CB parameter ClmTrackStart::Exec etc. /Thanks HansN -Original Message- From: Gary Lee Sent: den 4 juli 2018 03:16 To: Minh Hon Chau ; Hans Nordebäck Cc: opensaf-devel@lists.

Re: [devel] [PATCH 1/1] amfd: check for queued updates on attribute [#2884]

Hi Gary, a minor comment below. /Regards HansN On 07/06/2018 04:07 AM, Gary Lee wrote: If there is a queued update on a particular object's attribute, also queue further 'sync' updates so we don't end up with an inconsistent value. --- src/amf/amfd/imm.cc | 35 +-

[devel] [PATCH 0/1] Review Request for amf: add support for container/contained [#70]

Summary: amf: add support for container/contained [#70] Review request for Ticket(s): 70 Peer Reviewer(s): Nagu, Hans, Ravi, Gary Pull request to: Affected branch(es): develop Development branch: ticket-70 Base revision: 7f6f6c0531a0f5e4f2b0dc1abf4bab6962a3d1a9 Personal repository: git://git.code.s

Re: [devel] [PATCH 1/1] amfd: check for queued updates on attribute [#2884]

Hi Hans I was thinking typeid would be cheaper than using dynamic_cast. But it does make the code more complicated than it needs to be. Gary On 31/7/18, 10:13 pm, "Hans Nordeback" wrote: Hi Gary, a minor comment below. /Regards HansN On 07/06/2018 04:07 AM

[devel] [PATCH 1/1] log: fix logtest 6 42 fail [#2903]

Test case logtest 2 49 creates some cfg app to test the limitation, then deleting these stream at the end. But the deleting fails due to timeout for waiting the implementer. After that test case logtest 6 42 need to create some cfg app and take the same stream name. That causes the creattion fail w

[devel] [PATCH 0/1] Review Request for log: fix logtest 6 42 fail [#2903]

Summary: log: fix logtest 6 42 fail [#2903] Review request for Ticket(s): 2903 Peer Reviewer(s): Vu, Lennart Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop,release Development branch: ticket-2903 Base revision: 7f6f6c0531a0f5e4f2b0dc1abf4bab6962a3d1a9 Pe

[devel] [PATCH 0/1] Review Request for amfd: remove redundant const_cast [#2907]

Summary: amfd: remove redundant const_cast [#2907] Review request for Ticket(s): 2907 Peer Reviewer(s): Hans, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2907 Base revision: 7f6f6c0531a0f5e4f2b0dc1abf4bab6962a3d1a9 Per

[devel] [PATCH 1/1] amfd: remove redundant const_cast [#2907]

--- src/amf/amfd/clm.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amf/amfd/clm.cc b/src/amf/amfd/clm.cc index e113a65f9..1e67ff389 100644 --- a/src/amf/amfd/clm.cc +++ b/src/amf/amfd/clm.cc @@ -631,7 +631,7 @@ AvdJobDequeueResultT ClmTrackStart::exec(AVD_CL_CB* cb

[devel] [PATCH 2/2] rded: perform KV store operations outside main thread [#2905]

Sometimes the 'watch' command in the KV plugin will not return a takeover request, if the KV store does not respond in time. Then rded would try to read the takeover request in the main thread after receiving a takeover request notification. This can cause rded to not respond to AMF callbacks in a

[devel] [PATCH 0/2] Review Request for rded: perform KV store operations outside main thread [#2905]

Summary: osaf: add function to read takeover requests [#2905] Review request for Ticket(s): 2905 Peer Reviewer(s): Anders, Hans, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2905 Base revision: 7f6f6c0531a0f5e4f2b0dc1ab

[devel] [PATCH 1/2] osaf: add function to read takeover requests [#2905]

--- src/osaf/consensus/consensus.cc | 17 + src/osaf/consensus/consensus.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc index 800b776e6..2a8e9bb1c 100644 --- a/src/osaf/consensus/consensus.cc +++ b/src/

Re: [devel] [PATCH 1/1] amfd: remove redundant const_cast [#2907]

Ack, review only/Thanks HansN -Original Message- From: Gary Lee Sent: den 1 augusti 2018 05:47 To: Hans Nordebäck ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] amfd: remove redundant const_cast [#2907] --- src/amf/amfd/clm.cc | 4 ++-- 1 file