Re: [devel] [PATCH 1/2] osaf: update etcd v2 plugin [#3003]

2019-01-28 Thread Hans Nordebäck
ack, review only/Thanks HansN On 1/24/19 02:17, Gary Lee wrote: > 'etcdctl watch' will return if connection to the etcd server is lost. > If that occurs, send a 'fake' takeover request to rded so rded > will reboot the node. This is in alignment with the etcd v3 plugin. > --- > src/osaf/consensu

Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split network [#3001]

2019-01-28 Thread Hans Nordebäck
Hi Vu, ack review only. Two comments below/Thanks HansN On 1/25/19 12:34, Vu Minh Nguyen wrote: > --- > scripts/opensaf_reboot | 33 +++-- > src/amf/amfd/ndproc.cc | 4 ++-- > src/base/ncssysf_def.h | 6 ++ > src/base/sysf_def.c | 10 ++ >

Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split network [#3001]

2019-01-28 Thread Hans Nordebäck
Hi Vu, See one more comment below/Thanks HansN -Original Message- From: Hans Nordebäck Sent: den 28 januari 2019 10:15 To: Vu Minh Nguyen ; Gary Lee ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split ne

Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split network [#3001]

2019-01-28 Thread Vu Minh Nguyen
Hi Hans, Thanks for your comments. See my comment inline. Thanks Regards, Vu > -Original Message- > From: Hans Nordebäck > Sent: Monday, January 28, 2019 4:37 PM > To: Hans Nordebäck ; Vu Minh Nguyen > ; Gary Lee ; > Minh Hon Chau > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re

Re: [devel] Review request imm: update PR documentation regarding empty value persisted [#2991]

2019-01-28 Thread Vu Minh Nguyen
Hi all, Any comment for this update? Will push the documentation E/today if getting no comment/response. Regards, Vu From: Vu Minh Nguyen Sent: Thursday, January 17, 2019 9:44 AM To: 'Lennart Lund' Cc: 'opensaf-devel@lists.sourceforge.net' Subject: [devel] Review request imm: update

Re: [devel] [PATCH 1/1] log: fix coredump at log agent application [#3002]

2019-01-28 Thread Vu Minh Nguyen
Hi, Have you had time to review this ticket? Thanks. Regards, Vu > -Original Message- > From: Vu Minh Nguyen > Sent: Thursday, January 24, 2019 5:15 PM > To: lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject:

[devel] [PATCH 0/1] Review Request for rded: process takeover request without delay [#3005]

2019-01-28 Thread Gary Lee
Summary: rded: process takeover request without delay [#3005] Review request for Ticket(s): 3005 Peer Reviewer(s): Minh, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3005 Base revision: d15ccea07385c89ae24fe44a66f3066e9a

[devel] [PATCH 1/1] rded: process takeover request without delay [#3005]

2019-01-28 Thread Gary Lee
Currently, a takeover request is not sent to the main thread immediately so that MDS messages related to topology changes are processed first. If the plugin informs us it has lost connectivity to the consensus service by returning 'UNDEFINED', or we prioritise the current active SC, then we should