ack, review only/Thanks HansN
On 1/24/19 02:17, Gary Lee wrote:
> 'etcdctl watch' will return if connection to the etcd server is lost.
> If that occurs, send a 'fake' takeover request to rded so rded
> will reboot the node. This is in alignment with the etcd v3 plugin.
> ---
> src/osaf/consensu
Hi Vu, ack review only. Two comments below/Thanks HansN
On 1/25/19 12:34, Vu Minh Nguyen wrote:
> ---
> scripts/opensaf_reboot | 33 +++--
> src/amf/amfd/ndproc.cc | 4 ++--
> src/base/ncssysf_def.h | 6 ++
> src/base/sysf_def.c | 10 ++
>
Hi Vu,
See one more comment below/Thanks HansN
-Original Message-
From: Hans Nordebäck
Sent: den 28 januari 2019 10:15
To: Vu Minh Nguyen ; Gary Lee
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split
ne
Hi Hans,
Thanks for your comments. See my comment inline. Thanks
Regards, Vu
> -Original Message-
> From: Hans Nordebäck
> Sent: Monday, January 28, 2019 4:37 PM
> To: Hans Nordebäck ; Vu Minh Nguyen
> ; Gary Lee ;
> Minh Hon Chau
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re
Hi all,
Any comment for this update? Will push the documentation E/today if getting
no comment/response.
Regards, Vu
From: Vu Minh Nguyen
Sent: Thursday, January 17, 2019 9:44 AM
To: 'Lennart Lund'
Cc: 'opensaf-devel@lists.sourceforge.net'
Subject: [devel] Review request imm: update
Hi,
Have you had time to review this ticket? Thanks.
Regards, Vu
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Thursday, January 24, 2019 5:15 PM
> To: lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
>
> Subject:
Summary: rded: process takeover request without delay [#3005]
Review request for Ticket(s): 3005
Peer Reviewer(s): Minh, Hans
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3005
Base revision: d15ccea07385c89ae24fe44a66f3066e9a
Currently, a takeover request is not sent to the main thread immediately
so that MDS messages related to topology changes are processed first.
If the plugin informs us it has lost connectivity to the consensus service
by returning 'UNDEFINED', or we prioritise the current active SC,
then we should