Re: [devel] [PATCH 1/1] amfnd: fix error reading from deallocated memory [#2568]

Thanks Hans, I will make a change and note the preferred style. Best Regards, Thanh -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: Tuesday, 4 June 2019 3:42 PM To: Thanh Nguyen; Gary Lee; Thuan Tran; Thang Duc Nguyen Cc:

Re: [devel] [PATCH 1/1] amfnd: fix error reading from deallocated memory [#2568]

Hi Thanh ack (review only). Thanks On 4/6/19 8:48 am, Thanh Nguyen wrote: Invalid read is from the following - avnd_evt_mds_ava_dn_evh() (amf/amfnd/comp.cc) - avsv_create_association_class_dn() (amf/common/util.c) Other changes are to fix cppcheck error report --- src/amf/amfnd/comp.cc | 16

[devel] [PATCH 0/1] Review Request for [#2568]

Summary: amfnd: fix error reading from deallocated memory [#2568] Review request for Ticket(s): 2568 Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE *** Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2568

[devel] [PATCH 1/1] amfnd: fix error reading from deallocated memory [#2568]

Invalid read is from the following - avnd_evt_mds_ava_dn_evh() (amf/amfnd/comp.cc) - avsv_create_association_class_dn() (amf/common/util.c) Other changes are to fix cppcheck error report --- src/amf/amfnd/comp.cc | 16 src/amf/common/util.c | 6 +++--- 2 files changed, 11

[devel] [PATCH 0/1] Review Request for log: Delete the older file without closing current log file [#3046]

Summary: log: Delete the older file without closing current log file [#3046] Review request for Ticket(s): 3046 Peer Reviewer(s): Lennart, Vu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3046 Base revision:

[devel] [PATCH 1/1] log: Delete the older file without closing current log file [#3046]

Improve the enhancement of ticket #3022, the user can rotate (delete) older log files without closing current log file. LOG add new parameter(optional) to admin op command with id = 2. - If parameter exists, LOGD rotates log file without closing current log file - If parameter is omitted, LOGD

Re: [devel] [PATCH 0/1] Review Request for mds: use new TIPC getsockopt to log receive buffer utilization [#3038]

Ack with minor comments: 1) When adding new files, don't add "(C) Copyright 20xx The OpenSAF Foundation" at the top of the file. Also, you don't need the Author(s): line. 2) You can use base::MillisToTimespec for converting milliseconds to a timespec structure. / Anders Widell mån 2019-05-20

[devel] [PATCH 1/1] amf: fix SU get stuck in INSTANTIATING presence state [#3047]

COMP restart recovery during SU restart recovery can lead to SU stuck in INSTANTIATING without further action. Because COMP instaniated event in RESTARTING does not trigger avnd_su_pres_fsm_run(). --- src/amf/amfnd/clc.cc | 4 src/amf/amfnd/susm.cc | 4 +++- 2 files changed, 7

[devel] [PATCH 0/1] Review Request for amf: fix SU get stuck in INSTANTIATING presence state [#3047]

Summary: amf: fix SU get stuck in INSTANTIATING presence state [#3047] Review request for Ticket(s): 3047 Peer Reviewer(s): Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3047 Base revision: