[devel] [PATCH 0/1] Review Request for amfd: correct handling complete/apply callback on standby sc [#3082]

Summary: amfd: correct handling complete/apply callback on standby sc [#3082] Review request for Ticket(s): 3082 Peer Reviewer(s): Gary, Minh, Thuan Pull request to: Gary Affected branch(es): develop Development branch: ticket-3082 Base revision: eac09bf540f33cf25ee2a8902aeeef40ee6bbf3b Person

[devel] [PATCH 1/1] amfd: correct handling complete/apply callback on standby sc [#3082]

During stanby SC comes up, AMF config objects are deleted on active SC. It causes NOT_EXIST error on standby node. AMFD on standby should ignore this error in this case. --- src/amf/amfd/app.cc| 29 - src/amf/amfd/comp.cc | 18 +++--- src/amf/a

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Vu, I see it, will add. Thanks Minh On 16/9/19 4:21 pm, Nguyen Minh Vu wrote: Hi Minh, See my responses to your comments below, started with [Vu2]. Regards, Vu On 9/16/19 1:06 PM, Minh Hon Chau wrote: Hi Vu, Several comments with [M] too :). Thanks Minh On 16/9/19 2:24 pm, Nguyen M

Re: [devel] [PATCH 5/9] mds: Add state machine for tipc portid instance [#1960]

Hi Vu, Some comments with [M] Thanks Minh On 16/9/19 2:56 pm, Nguyen Minh Vu wrote: Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch adds state machine to support tx probation timer. ---   src/mds/mds_tipc_fctrl_intf.cc   |  47 +++

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Minh, See my responses to your comments below, started with [Vu2]. Regards, Vu On 9/16/19 1:06 PM, Minh Hon Chau wrote: Hi Vu, Several comments with [M] too :). Thanks Minh On 16/9/19 2:24 pm, Nguyen Minh Vu wrote: Hi Minh, I have several comments below, started with [Vu]. Regards, V

Re: [devel] [PATCH 4/9] mds: Add timeout for ack message [#1960]

Hi Vu, Some comments with [M] Thanks Minh On 16/9/19 2:37 pm, Nguyen Minh Vu wrote: Hi Minh, I have minor comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: If the ack size is configured greater than 1, there should be a timeout at receiver ends to send the ack message back

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Vu, Several comments with [M] too :). Thanks Minh On 16/9/19 2:24 pm, Nguyen Minh Vu wrote: Hi Minh, I have several comments below, started with [Vu]. Regards, Vu On 8/14/19 1:01 PM, Minh Chau wrote: This is a collaborative patch of two participants: - Tran Thuan - Minh Chau Main ch

Re: [devel] [PATCH 5/9] mds: Add state machine for tipc portid instance [#1960]

Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch adds state machine to support tx probation timer. --- src/mds/mds_tipc_fctrl_intf.cc | 47 +++-- src/mds/mds_tipc_fctrl_msg.h | 1 + src/mds/mds_tipc_fctrl_portid.cc | 109 ++

Re: [devel] [PATCH 4/9] mds: Add timeout for ack message [#1960]

Hi Minh, I have minor comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: If the ack size is configured greater than 1, there should be a timeout at receiver ends to send the ack message back to senders. The ack message timeout utilizes the poll timeout in flow control thread to m

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Minh, I have several comments below, started with [Vu]. Regards, Vu On 8/14/19 1:01 PM, Minh Chau wrote: This is a collaborative patch of two participants: - Tran Thuan - Minh Chau Main changes: - Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files introduce new functions

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Hans, Gary, Vu Do you have any comments on remaining patches? Thanks Minh On 11/9/19 11:01 am, Minh Hon Chau wrote: Hi Gary, Thanks for the review, please find comments with [M]. /Minh On 10/9/19 6:02 pm, Gary Lee wrote: Hi Minh & Thuan Some minor comments marked with [GL]. On 14/8/1