Re: [devel] [PATCH 1/1] ntfd: Do not send response to client if client down [#3084]

2019-10-08 Thread Nguyen Minh Vu
Hi Thien, I have some comments below. I see this enhancement does not bring much value to NTF as it deals with a very rare case - process is terminated before saNtfInitialize() returns. In reality, if NTF server is getting overloaded by such process, there must be an error in that process.

[devel] [PATCH 1/1] ntfd: Do not send response to client if client down [#3084]

2019-10-08 Thread thien.m.huynh
Ntfd will not send response to a client when client already down. This will avoid timeout when ntfd send via mds. --- src/ntf/ntfd/NtfAdmin.cc | 93 src/ntf/ntfd/NtfAdmin.h | 3 ++ src/ntf/ntfd/ntfs_cb.h | 6 src/ntf/ntfd/ntfs_com.h | 3

[devel] [PATCH 0/1] Review Request for ntfd: Do not send response to client if client down V3 [#3084]

2019-10-08 Thread thien.m.huynh
Summary: ntfd: Do not send response to client if client down [#3084] Review request for Ticket(s): 3084 Peer Reviewer(s): Thuan, Vu, Minh Pull request to: Vu Affected branch(es): develop Development branch: ticket-3084 Base revision: cafbc5d02c90b57c7c94a7735ce8e002224b3d6b Personal repository:

Re: [devel] [PATCH 0/2] Review Request for mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2

2019-10-08 Thread Nguyen Minh Vu
Hi Minh, Ack from me. Thanks. Regards, Vu On 10/4/19 12:20 PM, Minh Chau wrote: Summary: mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2 Review request for Ticket(s): 3095 Peer Reviewer(s): Hans, Vu, Gary, Thuan Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***