Hi Phuc,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: phuc.h.chau
Sent: Thursday, October 24, 2019 10:28 AM
To: lennart.l...@ericsson.com; thuan.t...@dektech.com.au;
thang.d.ngu...@dektech.com.au; minh.c...@dektech.com.au;
gary@dektech.com.au
Cc: opensaf-devel@lists.
- Adapt MDS with this SNA implementation.
---
src/base/Makefile.am | 6 +-
src/base/sna.h | 126 +++
src/base/tests/sna_test.cc | 117
src/mds/mds_tipc_fctrl_intf.cc | 3 +-
src/mds/mds_tipc_fctrl_po
Summary: base: add serial number arithmetic (RFC1982) [#3074]
Review request for Ticket(s): 3074
Peer Reviewer(s): Minh, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3074
Base revision: 9b1c588a4f244cb34a304b03c7568e04fa
Summary: smf: Improve SmfAdminStateHandler() Return false if Fail [#3104]
Review request for Ticket(s): 3104
Peer Reviewer(s): Lennart Lund, Thuan Tran, Thang Nguyen
Pull request to: Minh Chau, Gary
Affected branch(es): develop
Development branch: ticket-3104
Base revision: 9b1c588a4f244cb34a304b03
SW upgrade testing, if found that if a service unit is in INSTANTIATION_FAILED,
one_step upgrade will not continue with the software installation.
---
src/smf/smfd/SmfAdminState.cc | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
mode change 100644 => 100755 src/smf/smfd/SmfAdminState
Hi Minh,
Please see my responses inline.
In general, I am trying to implement new version to reuse exist database.
Best Regards,
ThuanTr
From: Minh Hon Chau
Sent: Wednesday, October 23, 2019 12:23 PM
To: Tran Thuan ; 'Nguyen Minh Vu'
; hans.nordeb...@ericsson.com;
gary@dektech
Hi,
There is a issue with this change, I need consider more.
Please ignore this review for now.
Best Regards,
Phuc chau
-Original Message-
From: phuc.h.chau [mailto:phuc.h.c...@dektech.com.au]
Sent: Wednesday, October 23, 2019 03:28 PM
To: lennart.l...@ericsson.com; thuan.t...@dektech.c
SW upgrade testing, if found that if a service unit is in INSTANTIATION_FAILED,
one_step upgrade will not continue with the software installation.
---
src/smf/smfd/SmfAdminState.cc | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
mode change 100644 => 100755 src/smf/smfd/SmfAdminState
Summary: smf: Improve SmfAdminStateHandler() Return false if Fail [#3104]
Review request for Ticket(s): 3104
Peer Reviewer(s): Lennart Lund, Thuan Tran, Thang Nguyen
Pull request to: Minh Chau, Gary
Affected branch(es): develop
Development branch: ticket-3104
Base revision: 9b1c588a4f244cb34a304b03
