Re: [devel] [PATCH 1/1] osaf: return a help message if no parameter is specified [#3118]

2019-11-13 Thread Tran Thuan
Hi Gary, ACK from me. Best Regards, ThuanTr -Original Message- From: Gary Lee Sent: Wednesday, November 13, 2019 1:19 PM To: minh.c...@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] osaf: return a help message if no

Re: [devel] [PATCH 1/1] mds: fix sender take very long time to send all messages [#3119]

2019-11-13 Thread Minh Hon Chau
Hi Thuan, ack from me. THanks Minh On 13/11/19 10:00 pm, thuan.tran wrote: When overload happens, sender will wait for chunkAck to continue sending more messages, it should send number of message equal chunkAck size of receiver. If not, receiver don't receive enough messages to send chunkAck

Re: [devel] [PATCH 1/3] mds: Distinguish protocol version of fragment [#3111]

2019-11-13 Thread Minh Hon Chau
Hi Thuan, Please see my reply inline. Thanks Minh On 13/11/19 9:54 pm, Tran Thuan wrote: Hi Minh, See my comment inline. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Friday, November 8, 2019 5:33 PM To: hans.nordeb...@ericsson.com; gary@dektech.com.au;

[devel] [PATCH 1/1] mds: fix sender take very long time to send all messages [#3119]

2019-11-13 Thread thuan.tran
When overload happens, sender will wait for chunkAck to continue sending more messages, it should send number of message equal chunkAck size of receiver. If not, receiver don't receive enough messages to send chunkAck and wait until timer timeout to send chunkAck to sender. This loop will make

[devel] [PATCH 0/1] Review Request for mds: fix sender take very long time to send all messages [#3119] V2

2019-11-13 Thread thuan.tran
Summary: mds: fix sender take very long time to send all messages [#3119] Review request for Ticket(s): 3119 Peer Reviewer(s): Minh, Vu, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3119 Base revision:

Re: [devel] [PATCH 2/3] mds: Refactor logging [#3111]

2019-11-13 Thread Tran Thuan
Hi, ACK from me. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Friday, November 8, 2019 5:33 PM To: hans.nordeb...@ericsson.com; gary@dektech.com.au; vu.m.ngu...@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh Chau

Re: [devel] [PATCH 3/3] mds: Add backward compatibility mdstest for fragment [#3111]

2019-11-13 Thread Tran Thuan
Hi, ACK from me. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Friday, November 8, 2019 5:33 PM To: hans.nordeb...@ericsson.com; gary@dektech.com.au; vu.m.ngu...@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh Chau

Re: [devel] [PATCH 1/3] mds: Distinguish protocol version of fragment [#3111]

2019-11-13 Thread Tran Thuan
Hi Minh, See my comment inline. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Friday, November 8, 2019 5:33 PM To: hans.nordeb...@ericsson.com; gary@dektech.com.au; vu.m.ngu...@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 1/1] mds: fix sender take very long time to send all messages [#3119]

2019-11-13 Thread Tran Thuan
Hi Minh, Agree with your latest comment. I will send out V2. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Wednesday, November 13, 2019 11:15 AM To: Tran Thuan ; 'Nguyen Minh Vu' ; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: