[devel] [PATCH 0/5] Review Request for log: improve the resilience of log service [#3116]

2019-11-28 Thread Vu Minh Nguyen
Summary: log: improve the resilience of log service [#3116] Review request for Ticket(s): 3116 Peer Reviewer(s): Lennart, Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3116 Base revision: 8e07c19aed63c249f4e7fa84702

[devel] [PATCH 3/5] saflogger: make timeout waiting for getting acknowledgment configurable [#3116]

2019-11-28 Thread Vu Minh Nguyen
Introducing a new option `-t second` or `--timeout=second` to let user input his desired timeout of waiting for write async acknowledgment. Default timeout is 20 seconds to keep saflogger backward compatible. --- src/log/tools/saf_logger.c | 29 ++--- 1 file changed, 22 in

[devel] [PATCH 1/5] log: improve the resilience of log service [#3116]

2019-11-28 Thread Vu Minh Nguyen
In order to improve resilience of OpenSAF LOG service when underlying file system is unresponsive, a queue is introduced to hold async write request up to an configurable time that is around 15 - 30 seconds. The readiness of the I/O thread will periodically check, and if it turns to ready state, t

[devel] [PATCH 5/5] log: add test cases of improving the log resilience [#3116]

2019-11-28 Thread Vu Minh Nguyen
Adding 08 new test cases into 02 suites: 1) Suite 20 with 07 test cases, including: - Test changing queue size & resilient timeout; - Test if a write async is dropped if its timeout setting is overdue, also verify if log server has kept the request in proper time. - Test if getting write callback r

[devel] [PATCH 4/5] log: update README file for improvement of log resilience [#3116]

2019-11-28 Thread Vu Minh Nguyen
--- src/log/README | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/log/README b/src/log/README index b83d472e4..ab96a8157 100644 --- a/src/log/README +++ b/src/log/README @@ -764,3 +764,41 @@ on AMF role is unnecessary delay the CLM state of a Node

[devel] [PATCH 2/5] log: notify all lost log records when cluster goes to headless [#3116]

2019-11-28 Thread Vu Minh Nguyen
This change introduces a light list keeping all invocations that not yet get the acknowledgement from log server. If the server is disappeared in case of headless, log agent will notify all lost invocations to log client with error code SA_AIS_ERR_TRY_AGAIN. --- src/log/agent/lga_agent.cc | 2 ++

[devel] [PATCH 1/2] mds: Improve readibility [#3089]

2019-11-28 Thread Minh Chau
Correct indent and reduce code lines (<80 chars) for mds_mdtm_send_tipc() and mdtm_frag_and_send() --- src/mds/mds_dt_tipc.c | 490 ++ 1 file changed, 256 insertions(+), 234 deletions(-) diff --git a/src/mds/mds_dt_tipc.c b/src/mds/mds_dt_tipc.c ind

[devel] [PATCH 0/2] Review Request for mds: Avoid message reallocation [#3089] V3

2019-11-28 Thread Minh Chau
Summary: mds: Avoid message reallocation [#3089] Review request for Ticket(s): 3089 Peer Reviewer(s): Thuan, Vu, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3089 Base revision: 8e07c19aed63c249f4e7fa8470270d2de1a56046 P

[devel] [PATCH 2/2] mds: Avoid message reallocation [#3089]

2019-11-28 Thread Minh Chau
The patch avoids message reallocation if the message is in retransmission queue --- src/mds/mds_dt_tipc.c| 68 +++- src/mds/mds_tipc_fctrl_intf.cc | 6 ++-- src/mds/mds_tipc_fctrl_intf.h| 4 +-- src/mds/mds_tipc_fctrl_msg.cc| 2 +- src/m

Re: [devel] [PATCH 1/1] mds: Fix mds flow control keep all messages in queue [#3123]

2019-11-28 Thread Minh Hon Chau
Hi Thuan, ack with comments. Thanks Minh On 28/11/19 6:55 pm, thuan.tran wrote: When overflow happens, mds with flow control enabled may keep all messages in queue if it fails to send a message when receiving Nack or ChunkAck since no more trigger come after that. MDS flow control should retr