Summary: mds: Using timer to continue sending queued messages [#3127]
Review request for Ticket(s): 3127
Peer Reviewer(s): Minh, Vu, Thang, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3127
Base revision:
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, December 10, 2019 9:51 AM
To: thuan.tran ; 'Nguyen Minh Vu'
; 'thang . d . nguyen'
; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] mds: fix ckpt 20 11 failure
Hi Thuan,
- We could give the patch title a bit more meanings than "fix ckpt 20
11..", for example, something as "Using timer to continue sending queued
message".
- And a few comments inline
Thanks
Minh
On 5/12/19 3:05 pm, thuan.tran wrote:
- In overflow, receive chunk ack may stuck in
Hi Vu,
Thanks. See my replies inline.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Monday, December 9, 2019 6:18 PM
To: Tran Thuan ; lennart.l...@ericsson.com;
gary@dektech.com.au; minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject:
Hi Vu,
Thanks. See my reply inline.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Monday, December 9, 2019 6:30 PM
To: Tran Thuan ; lennart.l...@ericsson.com;
gary@dektech.com.au; minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re:
Hi Thuan,
See my responses inline.
Regards, Vu
On 12/9/19 5:35 PM, Tran Thuan wrote:
Hi Vu,
Some comments from me:
- Remove xid in test code.
OK
- Use AIS_EVALUATE() and SYS_EVALUATE() that you defined, but you still direct
use test_validate()/rc_validate()
The macros are used to
Hi Thuan,
See my responses inline.
Regards, Vu
On 12/9/19 5:32 PM, Tran Thuan wrote:
Hi Vu,
Some comments from me:
- I think need remove xid name in code.
OK
- CleanOverdueData() should loop to clean all overdue records stead of just one
overdue record.
No. It should only serve one
Hi Vu,
Some comments from me:
- Remove xid in test code.
- Use AIS_EVALUATE() and SYS_EVALUATE() that you defined, but you still direct
use test_validate()/rc_validate()
- polling_thread() is create thread and wait it done, why not directly call the
function?
- In case of reboot SCs for
Hi Vu,
Some comments from me:
- I think need remove xid name in code.
- CleanOverdueData() should loop to clean all overdue records stead of just one
overdue record.
- In PeriodicCheck, don't need check is_iothread_ready() before Flush() because
it is checked inside Flush()
- Flush() mean
