Hi Thuan,
Ack with comments inline.
Regards, Vu
On 2/12/20 5:36 PM, thuan.tran wrote:
- Adapt MDS with this SNA implementation.
---
src/base/Makefile.am | 6 +-
src/base/sna.h | 136 +++
src/base/tests/sna_test.cc | 117
Summary: base: fix creation of msg queues [#3107]
Review request for Ticket(s): 3107
Peer Reviewer(s): Mathi
Pull request to:
Affected branch(es): develop
Development branch: ticket-3107
Base revision: b8ab2c8a180b5b1ba110a02ecd60a1001ebddbc6
Personal repository: git://git.code.sf.net/u/trguitar/r
Message queues stop working correctly after queue file is removed from /tmp.
Message queue API uses "ftok" which relies on the file being permanent. The
behaviour is undefined if the file is removed. Many systems clean out /tmp
periodically, so this can break if the message queue is long lived.
C
Hi Vu,
Thanks for comments. Please check my replies inline.
Best Regards,
ThuanTr
From: Nguyen Minh Vu
Sent: Thursday, February 13, 2020 5:50 PM
To: Thuan Tran ; Minh Hon Chau
; Thang Duc Nguyen ;
Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] base: add serial numb
Summary: amfnd: should wait for IR thread ready to send event [#3153]
Review request for Ticket(s): 3153
Peer Reviewer(s): Minh, Thang, Vu, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3153
Base revision: b8ab2c8a180b5b1
There is a case imm reader (IR) thread is not yet created but
main thread send event to its mailbox then fail, lead to abnormal
state for node.
Main thread will check IR thread up and ready to send event.
---
src/amf/amfnd/imm.cc | 3 +++
src/amf/amfnd/main.cc | 10 ++
2 files changed, 1
With SU contains more 2 components. During start up, if component_1
is instanted and component_2 is in instantiating. Restart adm op is
invoked on component_1. Then component_2 is instantiated following
by component_1 re-instantiated. The SU will be stuc in INSTANTIATING
presence state.
---
src/am
Summary: amfnd: trigger SU FSM [#3152]
Review request for Ticket(s): 3152
Peer Reviewer(s): Minh, Gary, Thuan
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3152
Base revision: b8ab2c8a180b5b1ba110a02ecd60a1001ebddbc6
Personal
