[devel] [PATCH 1/1] rde: update mds registration when switched to Active role [#3159]

2020-02-26 Thread thuan.tran
--- src/rde/rded/role.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rde/rded/role.cc b/src/rde/rded/role.cc index fdb0d845e..402e75a9a 100644 --- a/src/rde/rded/role.cc +++ b/src/rde/rded/role.cc @@ -150,8 +150,10 @@ void Role::NodePromoted() { // promoted to active from election

[devel] [PATCH 0/1] Review Request for rde: update mds registration when switched to Active role [#3159]

2020-02-26 Thread thuan.tran
Summary: rde: update mds registration when switched to Active role [#3159] Review request for Ticket(s): 3159 Peer Reviewer(s): Gary, Minh, Vu, Thang Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3159 Base revision: 4bb1251589

Re: [devel] [PATCH 1/1] imm: imm_list tool add new option --delimeter [#3155]

2020-02-26 Thread Thuan Tran
Hi Phuc, In general, please do not change what is not need, e.g: add new line, etc... Some typo: "delimeter" -> "delimiter", and other comments inline. One question, why not support just one character as delimiter? Why a string? Best Regards, ThuanTr -Original Message- From: Phuc Hoang C

Re: [devel] [PATCH 1/1] imm: imm_list tool add new option --delimiter [#3155]

2020-02-26 Thread Phuc Hoang Chau
Hi Thuan, Thanks for your spent time to review. I will update your comments. Best Regards, Phuc Chau -Original Message- From: Thuan Tran Sent: Wednesday, February 26, 2020 05:20 PM To: Phuc Hoang Chau ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] im

[devel] [PATCH 1/1] amfnd: handle comp instantiate event with SU in terminating presence state [#3160]

2020-02-26 Thread thang.d.nguyen
- When component is instantiated with SU in terminating presence state, need trigger SU fsm with instantiate event if all components are either uninstantiated or instantiated. - Need informing error recovery when amfnd fails to send callback parameters to component when component already exited. --

[devel] [PATCH 0/1] Review Request for amfnd: handle comp instantiate event with SU in terminating presence state [#3160]

2020-02-26 Thread thang.d.nguyen
Summary: amfnd: handle comp instantiate event with SU in terminating presence state [#3160] Review request for Ticket(s): 3160 Peer Reviewer(s): Minh, Thuan, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3160 Base revisi