Re: [devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

Hi Thuan, Thanks for your comment. Best Regards, ThienHuynh -Original Message- From: Thuan Tran Sent: Tuesday, April 7, 2020 6:51 PM To: Vu Minh Nguyen ; Thien Minh Huynh Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] log: log content is placed in a file of another

Re: [devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

Hi Thien, ACK with minor comment inline. Best Regards, ThuanTr -Original Message- From: Vu Minh Nguyen Sent: Tuesday, April 7, 2020 5:27 PM To: Thien Minh Huynh ; Thuan Tran Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] log: log content is placed in a file of

Re: [devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

Ack. Regards, Vu On 4/7/20 4:33 PM, thien.m.huynh wrote: --- src/log/logd/lgs_filehdl.cc | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc index 0d7fb2b74..362df4c27 100644 ---

[devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

--- src/log/logd/lgs_filehdl.cc | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc index 0d7fb2b74..362df4c27 100644 --- a/src/log/logd/lgs_filehdl.cc +++ b/src/log/logd/lgs_filehdl.cc @@ -26,6 +26,7 @@

[devel] [PATCH 0/1] Review Request for log: log content is placed in a file of another stream [#3175] V2

Summary: log: log content is placed in a file of another stream [#3175] Review request for Ticket(s): 3175 Peer Reviewer(s): Thuan, Vu Pull request to: Thuan Affected branch(es): develop Development branch: ticket-3175 Base revision: 5a43fb3e0243fb48125f6eec88aeb1c3ef83fc7d Personal repository:

Re: [devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

Hi Thuan and Vu, Thanks for your comment. I will update it. Best Regards, ThienHuynh From: Vu Minh Nguyen Sent: Tuesday, April 7, 2020 2:43 PM To: Thien Minh Huynh ; Thuan Tran Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] log: log content is placed in a file of

Re: [devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

Hi Thien, Given file_name_find_g = "testme". Is filter_logfile_name() expected to return true if finfo->d_name = "testme_20200407_143120_20200407_153120.log"? or finfo->d_name = "testme_2.log.log"? To me, it is better to use regular expression to assure that it only returns true if

Re: [devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

Hi Thien, If d_name = "abcd1_123xxx" and file_name_find_g = "abc", then your code still match. Can you try to use regex which is available in c++11? For example: #include ... std::regex pattern1(file_name_find_g + "_[0-9]+_[0-9]+.log"); std::regex pattern2(file_name_find_g +

[devel] [PATCH 1/1] log: log content is placed in a file of another stream [#3175]

--- src/log/logd/lgs_filehdl.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc index 0d7fb2b74..238259454 100644 --- a/src/log/logd/lgs_filehdl.cc +++ b/src/log/logd/lgs_filehdl.cc @@ -965,8 +965,10 @@ static int

[devel] [PATCH 0/1] Review Request for log: log content is placed in a file of another stream [#3175]

Summary: log: log content is placed in a file of another stream [#3175] Review request for Ticket(s): 3175 Peer Reviewer(s): Thuan, Vu Pull request to: Thuan Affected branch(es): develop Development branch: ticket-3175 Base revision: 5a43fb3e0243fb48125f6eec88aeb1c3ef83fc7d Personal repository: