When NFS is unavailable, client try to write to log. Lgs server will put
it into the queue with the time. At this time, standby node startup and
cold sync. Cause of coredump due to duplicate data (CkptPushAsync) to
put queue is NULL.
The fix is adding a parametar CkptPushAsync into DecodeColdSync
Summary: lgs: fix data CkptPushAsync equals with encode cold sync [#3183]
Review request for Ticket(s): 3183
Peer Reviewer(s): Vu, Thuan
Pull request to: Thuan
Affected branch(es): develop
Development branch: ticket-3183
Base revision: b2497e28ef679c4d210955b058f710c1c6954220
Personal repository: g
Ack with minor comments.
On 5/11/20 2:11 PM, thien.m.huynh wrote:
When NFS is unavailable, client try to write to log. Lgs server will put
it into the queue with the time. At this time, standby node startup and
cold sync. Cause of coredump due to duplicate data (CkptPushAsync) to
put queue is NU
Hi Vu,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Vu Minh Nguyen
Sent: Monday, May 11, 2020 2:30 PM
To: Thien Minh Huynh ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] lgs: fix data CkptPushAsync equals with encode cold
Hi Thien,
In my understanding, push_async is vckpt_rec.
I wonder if below idea can solve the issue?
diff --git a/src/log/logd/lgs_cache.cc b/src/log/logd/lgs_cache.cc
index e3583e97c..27e33702d 100644
--- a/src/log/logd/lgs_cache.cc
+++ b/src/log/logd/lgs_cache.cc
@@ -344,14 +344,10 @@ int Cache:
Hi Thuan,
Thanks for your idea. Your idea can solve the issue. I will send V2.
Best Regards,
ThienHuynh
From: Thuan Tran
Sent: Tuesday, May 12, 2020 8:24 AM
To: Thien Minh Huynh ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] lgs: fix data CkptPushAsync equal
Summary: lgs: map the CkptPushAsync to the right memory [#3183]
Review request for Ticket(s): 3183
Peer Reviewer(s): Thuan, Vu
Pull request to: Thuan
Affected branch(es): develop
Development branch: ticket-3183
Base revision: b2497e28ef679c4d210955b058f710c1c6954220
Personal repository: git://git.c
The standby logsv is crashed during cold sync if having pending
write requests in the queue.That happens because the CkptPushAsync
data for decoding is referring to wrong data.
The fix is to map the CkptPushAsync to the right memory.
---
src/log/logd/lgs_cache.cc | 6 +-
1 file changed, 1 ins
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, May 12, 2020 1:33 PM
To: Thuan Tran ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] lgs: map the CkptPushAsync to the right memory [
