Hi Dat,

ACK from me with a minor comment.
In order to facilitate tracking, the incorrect ticket should be marked in the 
commit message or comment on 
#3337<https://sourceforge.net/p/opensaf/tickets/3337/>.

Best Regards,
Thien

________________________________
From: Dat Tran Quoc Phan <dat.tq.p...@dektech.com.au>
Sent: Wednesday, April 26, 2023 5:12 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thien Minh Huynh 
<thien.m.hu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net <opensaf-devel@lists.sourceforge.net>; 
Dat Tran Quoc Phan <dat.tq.p...@dektech.com.au>
Subject: [PATCH 1/1] mds: fix coredump when run mdstest using mds q_ownership 
[#3337]

This fix will remove a wrong freeing when mds recevies message.
Message buffer will only be freed by upper layer receiver.
---
 src/mds/mds_dt_common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mds/mds_dt_common.c b/src/mds/mds_dt_common.c
index 67b70a42c..85784e4b6 100644
--- a/src/mds/mds_dt_common.c
+++ b/src/mds/mds_dt_common.c
@@ -575,7 +575,6 @@ uint32_t mdtm_process_recv_message_common(uint8_t flag, 
uint8_t *buffer,
                 mds_mcm_ll_data_rcv(&reassem_queue->recv);

                 /* Free Memory allocated to this structure */
-               mdtm_free_reassem_msg_mem(&reassem_queue->recv.msg);
                 m_MMGR_FREE_REASSEM_QUEUE(reassem_queue);

                 return NCSCC_RC_SUCCESS;
--
2.17.1


_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to