Hi Hieu,
Ack. Tested with basic scenarios.
Thanks,
Quyen
On 10/27/2017 9:46 PM, Hieu Nguyen wrote:
---
python/Makefile.am |4 +-
python/pyosaf/utils/immoi/__init__.py| 456 ++
python/pyosaf/utils/immoi/implementer.py | 1009
Hi Hieu,
Please see my comments marked with [Quyen]
Thanks,
Quyen
On 10/26/2017 3:21 PM, Hieu Nguyen wrote:
---
python/pyosaf/utils/immoi/__init__.py| 275 +---
python/pyosaf/utils/immoi/implementer.py | 1006 --
python/pyosaf/utils/immom/__init__.py
Hi Hoa,
Ack from me. Tested with some basic scenarios.
Thanks,
Quyen
On 10/27/2017 6:14 PM, Hoa Le wrote:
Improved implementation of LOG pyosaf utils
The following comments shall be removed when the patch is pushed.
- This is the 3rd patch in the series of patches to improve the
Hi Long
Ack from me. Tested with some basic scenarios.
Thanks,
Quyen
On 10/27/2017 5:26 PM, Long H Buu Nguyen wrote:
- Add more error handling
- Refactor clm code
- Keep raising exceptions for existing python methods
- Add __version__ attribute to utils
---
python/pyosaf/utils/__init__.py
Hi Hoa,
Please find my comments marked with [Quyen]
Thanks,
Quyen
On 10/26/2017 3:33 PM, Hoa Le wrote:
Improved implementation of LOG pyosaf utils
The following comments shall be removed when the patch is pushed.
- This is the 3rd patch in the series of patches to improve the
Hi Hieu,
Ack from me.
Thanks,
Quyen
On 10/17/2017 12:47 PM, Hieu Nguyen wrote:
---
python/pyosaf/utils/__init__.py | 44 +++
python/pyosaf/utils/clm/__init__.py | 11 +
python/pyosaf/utils/immoi/__init__.py | 7 +++---
Hi Hieu,
Please see my comment marked with [Quyen].
Thanks,
Quyen
On 10/5/2017 5:26 PM, Hieu Nguyen wrote:
---
python/pyosaf/utils/__init__.py | 38 +++
python/pyosaf/utils/clm/__init__.py | 18 -
Hi Hieu,
Ack from me.
Thanks,
Quyen
On 10/17/2017 10:01 AM, Hieu Nguyen wrote:
---
python/pyosaf/utils/immom/object.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/pyosaf/utils/immom/object.py
b/python/pyosaf/utils/immom/object.py
index c2924d3..7d8ece8
Hi Hieu,
Please see my minor comment marked with [Quyen]
Thanks,
Quyen
On 10/3/2017 10:50 AM, Hieu Nguyen wrote:
---
python/pyosaf/utils/immom/object.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/pyosaf/utils/immom/object.py
Hi,
If there is no more comment, this patch will be pushed by next Monday
(2017-10-09)
Thanks,
Quyen
On 9/26/2017 12:54 PM, Gary Lee wrote:
Ack
Thanks
Gary
On 26/9/17, 2:56 pm, "Quyen Dao" <quyen@dektech.com.au> wrote:
Make SC status change callback style
Make SC status change callback style to be consistent with other AMF callbacks
* Define an alias named OsafAmfSCStatusChangeCallbackT for the SC status change
callback type
* Use osafAmfSCStatusChangeCallback as callback name
* Change "OsafAmfSCStatusT state" to "OsafAmfSCStatusT status"
---
Summary: amf: Improve SC status change callback style [#2594]
Review request for Ticket(s): 2594
Peer Reviewer(s): Gary, Hans, Praveen, Ravi
Pull request to: Gary
Affected branch(es): develop
Development branch: ticket-2594
Base revision: f3ef8eebf44f0eab4dcc65f83fe3119a77ef5067
Personal
Hi,
If no more comment, it will be pushed by tomorrow (2016/08/25)
Thanks,
Quyen
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: Wednesday, August 10, 2016 7:27 PM
To: Quyen Dao <quyen@dektech.com.au>; srikanth.revan...@oracle.com
Cc: o
Hi,
Please help review!
Thanks,
Quyen
-Original Message-
From: Quyen Dao [mailto:quyen@dektech.com.au]
Sent: Wednesday, May 25, 2016 11:45 AM
To: hans.nordeb...@ericsson.com; srikanth.revan...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] pyosaf
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset ea5807b590dbbaa235b5f368f7a0dd660e0fd214
Author: Quyen Dao <quyen@dektech.com.au>
Date: Wed, 25 May 2016 10:52:46 +0700
pyos
python/pyosaf/saAis.py | 5 +
python/pyosaf/saImm.py | 2 +-
python/pyosaf/saNtf.py | 3 ++-
3 files changed, 8 insertions(+), 2 deletions(-)
with this change, user can call str(sa_name_t_obj) to convert
SaNameT to str without caring it's extended or non extended.
unmarshalSaImmValue
Hi Praveen,
Please see my comments inline.
Thanks,
Quyen
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: Thursday, March 31, 2016 3:32 PM
To: Quyen Dao; 'Hans Nordebäck'; gary@dektech.com.au;
nagendr...@oracle.com
Cc: opensaf-devel
Hi Srikanth and Johan,
Could you please help review this patch?
Thanks,
Quyen
-Original Message-
From: Quyen Dao [mailto:quyen@dektech.com.au]
Sent: Wednesday, February 03, 2016 4:01 PM
To: hans.nordeb...@ericsson.com; srikanth.revan...@oracle.com;
johan.o.martens...@ericsson.com
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
After the nway application AMF entities are created, active amfd calls
avd_sg_nway_si_assign
function to assign any unassigned SI but all SUs are locked so no SI are
assigned
and the FSM is
python/pyosaf/saAis.py | 45 -
1 files changed, 36 insertions(+), 9 deletions(-)
Set enviroment variable SA_ENABLE_EXTENDED_NAMES to 1 in order to use
this extended SaNameT
diff --git a/python/pyosaf/saAis.py b/python/pyosaf/saAis.py
---
n
Other Y
Comments (indicate scope for each "y" above):
-
<>
changeset 1325333fe6225fe133d14c3f759c63c32e74f859
Author: Quyen Dao <quyen@dektech.com.au>
Date: Wed, 03 Feb 2016 14:21:47 +0700
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Friday, January 08, 2016 8:27 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au; minh.c...@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Friday, January 08, 2016 8:27 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au; minh.c...@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Thursday, December 24, 2015 1:34 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Thursday, December 10, 2015 1:43 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Wednesday, November 25, 2015 1:21 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 56a846d07f0093202d11bb89347e60709369bdfa
Author: Quyen Dao <quyen@dektech.com.au>
Date: Thu, 26 Nov 2015 14:25:0
configure.ac | 2 +
osaf/libs/agents/saf/amfa/Makefile.am | 2 +-
osaf/libs/agents/saf/amfa/tests/Makefile.am | 35 +++
osaf/services/saf/amf/amfnd/Makefile.am | 2 +-
osaf/services/saf/amf/amfnd/tests/Makefile.am |
Hi Praveen,
I got the below error when compiling the latest changeset with your patch.
comp.cc:1189:30: error: 'value' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
name = *((SaNameT *)value);
^
comp.cc:897:9: note: 'value' was
Hi Praveen,
When the cluster starts, the saAmfCtDefInstantiationLevel is .
root@SC-1:~# immlist -a saAmfCtDefInstantiationLevel
safVersion=4.0.0,safCompType=OpenSafCompTypeAMFWDOG
saAmfCtDefInstantiationLevel=
If I change saAmfCtDefInstantiationLevel to 1 then change it back to
.
It
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Wednesday, November 18, 2015 12:42 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Tuesday, November 17, 2015 3:57 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only)
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Tuesday, November 10, 2015 5:45 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
Hi Praveen,
Ack (Test only).
Tested 2 patches with the latest changeset (changeset: 7033:e03de11423ca)
on default branch.
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Wednesday, October 21, 2015 7:39 PM
To:
Hi Praveen,
I applied 2 patches on top of changeset: 7019:f378a750ff34. The presence
state transition works correctly during admin SU restart.
BUT the new code change causes the amfnd crash when restarting the NPI comp.
Here are the backtrace and syslog.
Backtrace
(gdb) bt full
#0
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
Subject: [devel] [PATCH 1 of 1] amfd: do not assign SUs on locked nodes
when ng is deleted. [#1507]
Date: Tue, 29 Sep 2015 12:37:07 +0530
From: praveen.malv...@oracle.com
To: hans.nordeb...@ericsson.com, nagendr...@oracle.com,
Hi Praveen,
Ack (Test only)
Thanks,
Quyen
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: Monday, September 28, 2015 4:25 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1
Hi Gary,
Ack from me (Test only)
Regards,
Quyen
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: Thursday, July 09, 2015 5:44 PM
To: praveen.malv...@oracle.com; nagendr...@oracle.com;
quyen@dektech.com.au; gary@dektech.com.au
Cc:
Hi Praveen,
I applied your patch on top of latest changeset 6631:593bc933f80c on default
branch and tried to verify
by following steps:
1. Start cluster
2. Load the NWayActive model (AppConfig-nwayactive.xml) and unlock-in then
unlock all the SUs
3. Create a node group containing PL-3 and PL-4
39 matches
Mail list logo
