Robert,
Ack & Reviewed.
-- Srikanth
On 11/21/2016 08:11 PM, Róbert Fekete A wrote:
> Hi Srikanth,
>
> Do you have any more comments on this patch?
>
> Thanks in advance
>
> /Robi
>
>
> On 10/28/2016 11:54 AM, Hans Nordeback wrote:
>> ack, code review only. Minor question, is the indentation fo
Praveen,
Here are the comments from me.
* PR DOC Page 46 * For an application to use this functionality,
AMF provides following new resources via saAmf.h:
[ Srikanth] New header file had been added .i.e saAmf_B_04_02.h, from
which the apis can be accessed but not the old file saAm
Ack. Reviewed.
I shall push the patch on Monday, if there are no more comments received.
-- Srikanth
On 07/21/2016 02:06 PM, Johan Mårtensson wrote:
> python/pyosaf/saNtf.py | 4 ++--
> python/pyosaf/utils/ntf/__init__.py | 4
> python/samples/ntfsubscribe | 2 +
Hi Vu,
There is an existing ticket for the issue mentioned (
https://sourceforge.net/p/opensaf/tickets/1330 )
-- Srikanth
- Original Message -
From: vu.m.ngu...@dektech.com.au
To: mahesh.va...@oracle.com, lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Sent: Tuesday
Ack, Tested.
-- Srikanth
- Original Message -
From: reddy.neelaka...@oracle.com
To: johan.o.martens...@ericsson.com, srikanth.revan...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Sent: Friday, May 6, 2016 5:46:03 PM GMT +05:30 Chennai, Kolkata, Mumbai, New
Delhi
Subject: [PATCH 1
h,
>>
>> Thanks for coming back to these patches. There are some limitations
>> in these that need improvement but I think it's good to push them as
>> a base.
>>
>> / Johan
>>
>> -Original Message-
>> From: Srikanth Revanuru [mai
Johan,
Ack. Tested the sample applications.
Couple of comments. "ntf" entry to Makefile.common and configure.ac
is to be done. The file saNtf.py is using SaAnyT, which is not imported.
I shall make those changes and push today.
Thanks,
Srikanth
On 11/06/2015 08:28 PM, Johan Mårtensson w
Hi Hans,
You can push the patch.
Code review only. Not tested.
-- Srikanth
On 03/23/2016 01:51 PM, Hans Nordebäck wrote:
> Hi Srikanth,
>
> A gentle reminder, do you have any comments on this patch? If not, I'll push
> this patch tomorrow.
>
> /Thanks HansN
>
> -Original Message-
> F
Ack, Reviewed.
/ Srikanth
On 09/29/2015 07:36 PM, Johan Mårtensson wrote:
> python/pyosaf/utils/immom/__init__.py | 13 -
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
>
> Add convenience function to immom utils to get error strings without
> marshalling of ctypes.
>
> dif
Ack. Only reviewed.
I shall push the patch if there are no further comments.
/Srikanth
On 09/29/2015 09:41 AM, Hung Nguyen wrote:
> python/pyosaf/saImmOm.py | 27 ++-
> 1 files changed, 26 insertions(+), 1 deletions(-)
>
>
> Add saImmOmCcbGetErrorStrings to saImmOm m
Johan,
Ack for all the patches.
Reviewed and tested. I am able to build the RPMS successfully with python
option enabled.
/ Srikanth
- johan.o.martens...@ericsson.com wrote:
> python/pyosaf/utils/immoi/__init__.py | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> Fix
Johan,
Comments inline
- johan.o.martens...@ericsson.com wrote:
> Hi Srikanth,
>
> Comments inline.
>
> / Johan
>
> -Original Message-----
> From: Srikanth Revanuru [mailto:srikanth.revan...@oracle.com]
> Sent: den 18 september 2015 11:01
> To: Joha
Johan,
Nice work. The sample applications depict the usage of different
features in IMMOI in a simple way.
Here are couple of comments.
-> The file python/pyosaf/utils/immoi/Makefile.am is not part of patch
sent. Because of which, compilation fails.
-> As the file python/samples/imm
Ack, Tested
/ Srikanth
- mahesh.va...@oracle.com wrote:
> 00-README.conf | 8 +-
> osaf/services/infrastructure/nid/scripts/configure_tipc.in | 83
> +-
> 2 files changed, 87 insertions(+), 4 deletions(-)
>
>
> Issue :
> ---
Johan,
I am in process of reviewing remaining patches and I shall post the
comments tomorrow morning, if any.
You can update the patches, once I complete the entire review.
/ Srikanth
--
Monitor Your Dynamic Infras
Johan,
The "tones" application doesn't provide the help text.
/ Srikanth
- johan.o.martens...@ericsson.com wrote:
> python/samples/immoi/samples/README|
> 93 ---
> python/samples/immoi/samples/interface-handler |
> 121 -
>
Johan,
The psutil module (> 2.0 version) used in the "users" sample application
doesn't
support the get_users() function. The function has been renamed to users().
/ Srikanth
- johan.o.martens...@ericsson.com wrote:
> python/samples/caps | 9 ++
Ack for all the patches. Tested the logger utility file.
The patch related to packaging the log directory needs to be re-generated
because of #1441 fix ( clm python bindings).
Minor comment inline.
- johan.o.martens...@ericsson.com wrote:
> Makefile.common | 1 +
> c
Johan,
Ack for all the patches. Tested.
Will push the same.
/ Srikanth
On 08/13/2015 06:36 PM, Johan Mårtensson wrote:
> python/samples/README | 5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>
> Add a description of the clm-tool sample application to the README.
>
> diff
Johan,
It seems that this patch file is not sent, along with the new 5 patches.
It would be easy for future reference, if you gather all the 6 patches and
send them as "version 2" or "V2"
Couple of comments inline.
- Original Message -
From: johan.o.martens...@ericsson.com
To:
Johan,
Comments inline.
Ack for the other 4 patches.
- johan.o.martens...@ericsson.com wrote:
> python/pyosaf/utils/clm/__init__.py | 43
> -
> python/samples/clm-listener | 39
> ++---
> 2 files changed, 77 insertio
Johan,
Quick comment : Changes pertaining to packaging the files as part of
rpm ( .i.e adding Makefile.am ) are missing.
/ Srikanth
On 08/10/2015 04:56 PM, Johan Mårtensson wrote:
> python/pyosaf/utils/clm/__init__.py | 103
>
> python/samples/clm-lis
Ack for all patches, Reviewed.
/ Srikanth
- johan.o.martens...@ericsson.com wrote:
> python/pyosaf/utils/__init__.py | 2 +-
> python/pyosaf/utils/immom/__init__.py | 3 ---
> python/pyosaf/utils/immom/ccb.py | 2 --
> python/pyosaf/utils/immom/iterator.py | 2 --
> 4 files c
Ack, Reviewed.
- Srikanth
- Original Message -
From: johan.o.martens...@ericsson.com
To: hans.nordeb...@ericsson.com, mathi.naic...@oracle.com,
hung.d.ngu...@dektech.com.au, srikanth.revan...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Sent: Monday, July 20, 2015 5:53:52 PM GMT +
Ack, Reviewed.
- Srikanth
- johan.o.martens...@ericsson.com wrote:
> python/pyosaf/utils/immom/__init__.py | 106
> +++--
> 1 files changed, 23 insertions(+), 83 deletions(-)
>
>
> The immom module contains decorated versions of the raw saImmOm
> functions tha
Johan,
Minor Comments inline.
Please raise a ticket, as sourceforge is back online.
- Srikanth
- johan.o.martens...@ericsson.com wrote:
> python/pyosaf/utils/__init__.py | 56
> +++
> python/pyosaf/utils/immom/__init__.py | 33
>
Ack, only reviewed.
- Srikanth
On 07/20/2015 01:06 PM, Johan Mårtensson wrote:
> python/pyosaf/saImm.py| 1 +
> python/pyosaf/utils/immom/__init__.py | 2 +-
> python/pyosaf/utils/immom/ccb.py | 9 ++---
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
>
> Add
>
> / Johan
>
> -Original Message-
> From: Srikanth Revanuru [mailto:srikanth.revan...@oracle.com]
> Sent: den 20 juli 2015 07:41
> To: Johan Mårtensson O; Hans Nordebäck; Anders Björnerstedt;
> mathi.naic...@oracle.com; Hung Nguyen D
> Cc: opensaf-devel@lists.s
Hi Johan,
A quick comment
Did you consider using function decorators instead of using wrapper like
functions. i.e. call_saf_function()!?
Also, if we goahead with this approach instead of decorator, we could
move call_saf_function() up one level above into the utils/__init__.py.
This way call_s
29 matches
Mail list logo
