Hello Thien,
Ack.
Regards, Thanh
-Original Message-
From: thien.m.huynh
Sent: Tuesday, 8 February 2022 7:59 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] imm: fix immnd crash when authenticate non-local
Hello Thien,
Ack from me.
Best Regards, Thanh
-Original Message-
From: thien.m.huynh
Sent: Tuesday, 17 August 2021 7:26 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] build: adaptive python version for rpm
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 472831daf2169a3fd42f0719a5116bc9b2916fbe
Author: Thanh Nguyen
Date: Fri, 27 Aug 2021 10:17:53 +1000
ntf: Fix compilation errors for 32 bit machine [#3279]
Patch for ticket 3277 failed compilation for 32 bit machine.
This p
Patch for ticket 3277 failed compilation for 32 bit machine.
This patch fixes these compilation errors.
---
src/ntf/ntfd/NtfSubscription.cc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/ntf/ntfd/NtfSubscription.cc b/src/ntf/ntfd/NtfSubscription.cc
index
Hello Thien,
Ack from me.
I have no further comments.
Best Regards,
Thanh
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, 26 May 2021 3:17 PM
To: Thanh Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] ntf: Enhance
and treated as
NTFSV_LOGGER_BUFFER_CAPACITY.
Best Regards,
Thanh
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, 6 May 2021 6:05 PM
To: Thanh Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] ntf: periodic logging alarm
Hi Anh and Thang,
Ack. No comment from me.
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, 26 April 2021 1:07 PM
To: Anh Tuan Le ; Thanh Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] pyosaf: support for amf api version b4.02 [#3256
Appropriate global variables in smfnd are placed under mutex
protection: smfnd_cb_t::smfd_dest, smfnd_cb_t::agent_cnt
---
src/smf/smfnd/smfnd.h | 1 +
src/smf/smfnd/smfnd_evt.c | 7 +++
src/smf/smfnd/smfnd_mds.c | 9 +
3 files changed, 17 insertions(+)
diff --git
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 8a37cdc5d686705ad5610269a55eb7e6be752f00
Author: Thanh Nguyen
Date: Wed, 31 Mar 2021 08:31:43 +1100
smf: Enhance handling of global variables [#2726]
Appropriate global variables in smfnd are placed under mutex
protection:
Hi Thien,
Ack.
Regards,
Thanh
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, 3 February 2021 7:42 PM
To: Thang Duc Nguyen ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] clm: use calloc instead malloc to remove garbage value
Ack from me.
The tile of the patch should start with "smf:" rather than "smd:".
Best Regards,
Thanh
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, 18 January 2021 2:32 PM
To: Thanh Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thang
Ack
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, 18 January 2021 5:14 PM
To: Thien Minh Huynh ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] pyosaf: update pyosaf support python3 [#3247]
Ack.
-Original Message-
From: Thien Minh
Hi Thuan,
ACK from me.
Regards,
Thanh
-Original Message-
From: Thuan Tran
Sent: Thursday, 17 September 2020 2:58 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] ntf: fix memleak detected by valgrind
1) Reuse existing functionality for deep clone of Imm Attr values.
2) Publish immutil internal memory management for external use
---
src/amf/amfd/imm.cc| 15 ++-
src/amf/amfd/imm.h | 8 +-
src/ntf/ntfimcnd/ntfimcn_imm.c | 52 +
src/ntf/ntfimcnd/ntfimcn_imm.h |
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 6314ad769499dda4b4ad125da456a86a285ecd40
Author: Thanh Nguyen
Date: Thu, 3 Sep 2020 15:14:48 +1000
imm: Enhance deep clone of Imm Attr values in immutil [#3215]
1) Reuse existing functionality for deep clone of Imm Attr
1) Reuse existing functionality for deep clone of Imm Attr values.
2) Publish immutil internal memory management for external use
---
src/amf/amfd/imm.cc| 15 ++-
src/amf/amfd/imm.h | 8 +-
src/ntf/ntfimcnd/ntfimcn_imm.c | 50 +
src/ntf/ntfimcnd/ntfimcn_imm.h |
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision a6bebd1e97602654fc24c3f625d731bc71e0afb3
Author: Thanh Nguyen
Date: Wed, 2 Sep 2020 11:27:35 +1000
imm: Enhance deep clone of Imm Attr values in immutil [#3215]
1) Reuse existing functionality for deep clone of Imm Attr
Hi Thuan,
Ack.
Regards, Thanh
-Original Message-
From: Thang Duc Nguyen
Sent: Wednesday, 19 August 2020 5:39 PM
To: Thuan Tran ; Minh Hon Chau
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] mbc: fix agent crash inside ncs_mbcsv_null_func()
[#3214]
Hi
Hi Thuan,
ACK from me.
As we discussed, this is followed up with a ticket to use internal memory
management.
Best Regards,
Thanh
-Original Message-
From: Thuan Tran
Sent: Monday, 17 August 2020 1:40 PM
To: Thanh Nguyen ; Thang Duc Nguyen
; Minh Hon Chau
Cc: opensaf-devel
Hi Thuan,
ACK from me.
Regards, Thanh
-Original Message-
From: Thuan Tran
Sent: Monday, 10 August 2020 6:14 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Thanh Nguyen ;
Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] mbc: fix memleak detected
The README file is update to reflect the implementation
in [#3169] and [#3200]
---
src/ntf/ntfimcnd/README | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/ntf/ntfimcnd/README b/src/ntf/ntfimcnd/README
index 2809e7eb9..507e57071 100644
--- a/src/ntf/ntfimcnd/README
+++
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision b77ab1b842c2e37f2699605dc0416a02e9f7a08b
Author: Thanh Nguyen
Date: Fri, 17 Jul 2020 09:52:04 +1000
ntf: Update README for NTF notification enhancement [#3201]
The README file is update to reflect the implementation
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 8531981f36b5474f1b189e753bbbc9ab3a1f27dd
Author: Thanh Nguyen
Date: Thu, 16 Jul 2020 18:49:42 +1000
ntf: Handle IMM multiple value attribute in notification [#3200]
When IMM changes an attribute with NOTIFY fla
When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
ntfimcn also fetches the old attribute values, corresponding to
the changed attribute values, if exist in IMM, and include the old
attribute values in notification data.
1)
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision f62824a37455117f5ff1eb36fa0e19d78b993f03
Author: Thanh Nguyen
Date: Thu, 16 Jul 2020 14:22:31 +1000
ntf: Update README for NTF notification enhancement [#3201]
The README file is update to reflect the implementation
The README file is update to reflect the implementation
in [#3169] and [#3200]
---
src/ntf/ntfimcnd/README | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/ntf/ntfimcnd/README b/src/ntf/ntfimcnd/README
index 2809e7eb9..cf0619979 100644
--- a/src/ntf/ntfimcnd/README
+++
Thx Minh,
When it gets ACKs from others, please help to merge.
In the mean time, I will update the MR with pro/cons. This kind of discussion
will also go to read me file.
Cheers,
Thanh
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, 15 July 2020 10:29 PM
To: Thanh Nguyen
When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
ntfimcn also fetches the old attribute values, corresponding to
the changed attribute values, if exist in IMM, and include the old
attribute values in notification data.
1)
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 4d0de8b21ce4033ace884c116089f8187f06ac53
Author: Thanh Nguyen
Date: Tue, 14 Jul 2020 10:44:26 +1000
ntf: Handle IMM multiple value attribute in notification [#3200]
When IMM changes an attribute with NOTIFY fla
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 991fbfd4fce0d400cf5bfb92af55fa2d4948d882
Author: Thanh Nguyen
Date: Fri, 10 Jul 2020 16:09:33 +1000
ntf: Enhance attribute change notification [#3196]
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends t
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
With the enhancement, ntfimcn fetches the old attribute values,
corresponding to the changed attribute values, if exist in IMM,
and include the old attribute values in
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision e7930bf61e3f54fa829f018ab069ee4918cc2f3c
Author: Thanh Nguyen
Date: Wed, 8 Jul 2020 17:11:51 +1000
ntf: Enhance attribute change notification V2 [#3196]
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
curre
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
With the enhancement, ntfimcn fetches the old attribute values,
corresponding to the changed attribute values, if exist in IMM,
and include the old attribute values in
Hi Minh,
Regard Id:2 and Id:3, I remove the old values.
I implement all comments.
Best Regards,
Thanh
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, 7 July 2020 11:43 AM
To: Thanh Nguyen ; Thang Duc Nguyen
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
With the enhancement, ntfimcn fetches the old attribute values,
corresponding to the changed attribute values, if exist in IMM,
and include the old attribute values in
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision e3eb3f02f5dd76d8bbf190b6420db3b364138e01
Author: Thanh Nguyen
Date: Mon, 6 Jul 2020 07:11:08 +1000
ntf: Enhance attribute change notification [#3196]
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends t
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
With the enhancement, ntfimcn fetches the old attribute values,
corresponding to the changed attribute values, if exist in IMM,
and include the old attribute values in
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision ee44982166d7d3d2102e5eb96ffd3f32f94a0182
Author: Thanh Nguyen
Date: Fri, 3 Jul 2020 18:27:59 +1000
ntf: Enhance attribute change notification [#3196]
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends t
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
With the enhancement, ntfimcn fetches the old attribute values,
corresponding to the changed attribute values, if exist in IMM,
and include the old attribute values in
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 227d2a0dd547ad38c62fdf24f335eba6e73d2ade
Author: Thanh Nguyen
Date: Fri, 3 Jul 2020 17:42:47 +1000
ntf: Enhance attribute change notification [#3196]
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends t
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision f0ed54ab096dfc73afa070be37476e4a49eea080
Author: Thanh Nguyen
Date: Tue, 30 Jun 2020 21:18:56 +1000
ntf: Enhance attribute change notification [#3196]
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends t
1) When IMM changes an attribute with NOTIFY flag, ntfimcn
currently sends the changed attribute values in notification data.
With the enhancement, ntfimcn fetches the old attribute values,
corresponding to the changed attribute values, if exist in IMM,
and include the old attribute values in
When IMM changes an attribute with NOTIFY flag,
ntfimcn currently sends the changed attribute values
in notification data.
With the enhancement, ntfimcn fetches the old
attribute values, corresponding to the changed
attribute values, if exist in IMM, and include
the old attribute values in
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 9266a7c64afce76671f2619e3e9838bade4261c2
Author: Thanh Nguyen
Date: Mon, 29 Jun 2020 21:07:59 +1000
ntf: Enhance attribute change notification [#3196]
When IMM changes an attribute with NOTIFY flag,
ntfimcn currently sends t
1) The trace showed that during saImmOiCcbCompletedCallback,
when exchanged messages to fetch the old values, message
IMMA_CALLBACK_OI_CCB_APPLY is posed in the mailbox.
It is concluded that the old values are no longer
available at saImmOiCcbObjectModifyCallback.
2) It also expect comments if
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 56f4cce71f6d0ba4eef57f1a1e6221c16c0067f7
Author: Thanh Nguyen
Date: Mon, 15 Jun 2020 10:34:29 +1000
ntf: Enhance attribute change notification [#3196]
1) The trace showed that during saImmOiCcbCompletedCallback,
when exchange
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 271ba733c12db4d75f9da1c9d2f313d303ac3c61
Author: Thanh Nguyen
Date: Fri, 12 Jun 2020 18:56:59 +1000
ntf: Enhance attribute change notification [#3196]
The purpose of this interim patch is to indicate that
the old attribute
Hi Thuan,
I have a minor comment and also an ACK.
Dealing with event interactions, we try not to introduce new variable such as
running. We tend to use existing variable as much as we can. This will make
further interactions update simpler.
The existing variable is_fctrl_enabled can be used
Hello Thien,
We should mention that this is installation time configurable attribute.
Best Regards,
Thanh
-Original Message-
From: Thanh Nguyen [mailto:thanh.ngu...@dektech.com.au]
Sent: Friday, 7 February 2020 1:26 PM
To: 'Thien Minh Huynh'; 'Gary Lee'; 'Minh Chau'
Cc: 'opensaf-devel
Hello Thien,
1) General comment.
1.1) The document introduces concepts and entities such as Log Server, Log
Agent, log stream, log record, ... We should use these already introduced
terms. New terms should be introduced properly.
Chapter 6 uses the term "server" as in "The server is now able to
In the trace record the time value is generated
after acquiring the mutex. The time accuracy is improved
when generated before seizing the mutext.
---
src/base/logtrace.cc| 2 +-
src/base/logtrace_client.cc | 15 ---
src/base/logtrace_client.h | 9 +
3 files
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision b02569e50913fa8697ba087b25b3accae2b0069e
Author: Thanh Nguyen
Date: Thu, 6 Feb 2020 15:30:09 +1100
dtm: improve time accuracy in a trace record [#3144]
In the trace record the time value is generated
after acquiring the mutex
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 3a7d9c5f43233124cb866c4b4e9076cbcd5417b8
Author: Thanh Nguyen
Date: Thu, 6 Feb 2020 15:16:37 +1100
dtm: improve time accuracy in a trace record [#3144]
In the trace record the time value is generated
after acquiring the mutex
In the trace record the time value is generated
after acquiring the mutex. The time accuracy is improved
when generated before seizing the mutext.
---
src/base/logtrace.cc| 2 +-
src/base/logtrace_client.cc | 17 ++---
src/base/logtrace_client.h | 9 +
3 files
version of (2) and (3) if it is confirmed that there is
no client code calling CreateLogEntry(..).
Best Regards,
Thanh
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: Thursday, 6 February 2020 12:48 PM
To: Thanh Nguyen; peter.mcint...@dektech.com.au
Cc: opensaf
In the trace record the time value is generated
after acquiring the mutex. The time accuracy is improved
when generated before seizing the mutext.
---
src/base/logtrace.cc| 2 +-
src/base/logtrace_client.cc | 18 +-
src/base/logtrace_client.h | 13 ++---
3 files
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision ed3466d17c9df07b54cd801177f20743c1b398f5
Author: Thanh Nguyen
Date: Fri, 24 Jan 2020 11:22:41 +1100
dtm: improve time accuracy in a trace record [#3144]
In the trace record the time value is generated
after acquiring the mutex
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 3122e85c2c54e467dbbdba04acfbfce7c46c9c17
Author: Thanh Nguyen
Date: Thu, 23 Jan 2020 17:00:17 +1100
dtm: improve time value in a trace record [#3144]
In the trace record the time value is generated
after acquiring the mutex. The
In the trace record the time value is generated
after acquiring the mutex. The time value is improved
when generated before seizing the mutext.
---
src/base/logtrace.cc| 2 +-
src/base/logtrace_client.cc | 18 +-
src/base/logtrace_client.h | 13 ++---
3 files
Hi Phuc,
ACK from me.
Cheers,
thanh
-Original Message-
From: Tran Thuan [mailto:thuan.t...@dektech.com.au]
Sent: Thursday, 24 October 2019 5:04 PM
To: 'phuc.h.chau'; lennart.l...@ericsson.com; thang.d.ngu...@dektech.com.au;
minh.c...@dektech.com.au; gary@dektech.com.au
Cc:
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 89397fe5fc1dc1a80d931871c31becde45409a71
Author: Thanh Nguyen
Date: Mon, 26 Aug 2019 15:16:43 +1000
smf: Fix c-linkage and string op errors V3 [#3065]
- Fix faults in C linkage in file
src/smf/smfd/SmfUtils.h.
- Fix fault
- Fix faults in C linkage in file
src/smf/smfd/SmfUtils.h.
- Fix fault in string concatenation in file
src/smf/smfd/SmfUpgradeCampaign.cc
---
src/smf/smfd/SmfUpgradeCampaign.cc | 3 ++-
src/smf/smfd/SmfUtils.h| 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 55631b6dd1e4283b643d52804fc6e8a680ce09a5
Author: Thanh Nguyen
Date: Mon, 26 Aug 2019 11:36:13 +1000
smf: Fix c-linkage and string op errors V2 [#3065]
- Fix faults in C linkage in file
src/smf/smfd/SmfUtils.h.
- Fix fault
Hi Vu,
I have changed the patch according to the comments.
I will push the patch after testing.
Best Regards,
Thanh
-Original Message-
From: Nguyen Minh Vu [mailto:vu.m.ngu...@dektech.com.au]
Sent: Thursday, 22 August 2019 9:06 PM
To: Thanh Nguyen; gary@dektech.com.au; thang.d.ngu
Faults in C linkage for PBE area is fixed.
---
src/smf/smfd/SmfUpgradeCampaign.cc | 3 ++-
src/smf/smfd/SmfUtils.cc | 14 ++
src/smf/smfd/SmfUtils.h| 10 --
3 files changed, 24 insertions(+), 3 deletions(-)
diff --git
** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 5877ece8c04aea7914efad6481faded44790607c
Author: Thanh Nguyen
Date: Tue, 20 Aug 2019 10:36:20 +1000
smf: Fix c-linkage errors [#3065]
Faults in C linkage for PBE area is fixed.
Complete diffstat:
--
src/smf/smfd/SmfUpgradeC
In IMM, for PBE, IMM uses the mix type of unsigned int
and signed int for Class ID and Object ID. These data are
stored in sqlite3 data base as 32-bit integers. Cast
is used when reading data back from sqlite3 data base.
Applying Google C++ Style Guide, Class ID and Object
ID are now signed int.
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision f697ae3e82908632a8bb9265de345143927b5a4f
Author: Thanh Nguyen
Date: Fri, 9 Aug 2019 09:59:03 +1000
imm: Fix Object ID and Class ID type inconsistency [#2770]
In IMM, for PBE, IMM uses the mix type of unsigned int
and
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision f697ae3e82908632a8bb9265de345143927b5a4f
Author: Thanh Nguyen
Date: Fri, 9 Aug 2019 09:59:03 +1000
imm: Fix Object ID and Class ID type inconsistency [#2770]
In IMM, for PBE, IMM uses the mix type of unsigned int
and
In IMM, for PBE, IMM uses the mix type of unsigned int
and signed int for Class ID and Object ID. These data are
stored in sqlite3 data base as 32-bit integers. Cast
is used when reading data back from sqlite3 data base.
Applying Google C++ Style Guide, Class ID and Object
ID are now signed int.
Invalid read is from the following
- avnd_evt_mds_ava_dn_evh() (amf/amfnd/comp.cc)
- avsv_create_association_class_dn() (amf/common/util.c)
Other changes are to fix cppcheck error report
---
src/amf/amfnd/comp.cc | 17 +
src/amf/common/util.c | 6 +++---
2 files changed, 12
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 9be484f49579861f2c3325403b7680b700d47c0b
Author: Thanh Nguyen
Date: Wed, 5 Jun 2019 12:11:31 +1000
amfnd: fix error reading from deallocated memory [#2568]
Invalid read is from the following
- avnd_evt_mds_ava_dn_evh()
Thanks Hans,
I will make a change and note the preferred style.
Best Regards,
Thanh
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: Tuesday, 4 June 2019 3:42 PM
To: Thanh Nguyen; Gary Lee; Thuan Tran; Thang Duc Nguyen
Cc: opensaf-devel
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 6262b7ce828b8080cb2f05942b422091afb18c3a
Author: Thanh Nguyen
Date: Mon, 3 Jun 2019 16:24:20 +1000
amfnd: fix error reading from deallocated memory [#2568]
Invalid read is from the following
- avnd_evt_mds_ava_dn_evh()
Invalid read is from the following
- avnd_evt_mds_ava_dn_evh() (amf/amfnd/comp.cc)
- avsv_create_association_class_dn() (amf/common/util.c)
Other changes are to fix cppcheck error report
---
src/amf/amfnd/comp.cc | 16
src/amf/common/util.c | 6 +++---
2 files changed, 11
ERIES HERE ***
revision 91806d17b2d79138f68ff3eb3449a9a6ba3dfbf0
Author: Thanh Nguyen
Date: Wed, 20 Feb 2019 16:01:08 +1100
clm: Incorrect encode/decode time_super [#3007]
Changing ecoding of time_super using 64 bit instead of 32 bit.
Complete diffstat:
--
src/clm/clmd/clms_mds.cc
Changing ecoding of time_super using 64 bit instead of 32 bit.
---
src/clm/clmd/clms_mds.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/clm/clmd/clms_mds.cc b/src/clm/clmd/clms_mds.cc
index 833d18c..5a77885 100644
--- a/src/clm/clmd/clms_mds.cc
+++
77 matches
Mail list logo
