[devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-21 Thread Minh Chau
Summary: ntfd: Checkpoint reader to the standby when processes reader API requests [#2757] Review request for Ticket(s): 2757 Peer Reviewer(s): Lennart, Srinivas, Canh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2757 Base r

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-22 Thread Lennart Lund
Hi Minh Ack. I have not tested much Have you tested using the reader API while running old version on standby and new version on active and vice versa (upgrade case)? Limitations? PR documentation update? Thanks Lennart > -Original Message- > From: Minh Hon Chau > Sent: den 22 januari

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-23 Thread minh . chau
Hi Lennart, I tested the APIs between versions with/without the changes. I will send out for review the README and PR change after the code review is done. One limitation is that both active and standby require the patches to work. Thanks, Minh > Hi Minh > > Ack. I have not tested much > > Have

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-28 Thread Minh Hon Chau
Hi all, If the patch look ok to you, I would like to push it tomorrow. I have updated the README and PR doc at the below links, if you have time please have a look. https://sourceforge.net/p/opensaf/tickets/_discuss/thread/77619155/0a9b/attachment/2757_README.diff https://sourceforge.net/p/o

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-28 Thread Canh Van Truong
Hi aMinh, Ack from me. Thanks Canh -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Monday, January 22, 2018 11:19 AM To: lennart.l...@ericsson.com; srinivas.mangip...@oracle.com; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh Chau

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-29 Thread Srinivas Mangipudy
Hi Minh, I got a build error. Below is the error; CCLD bin/ntfread lib/.libs/libSaNtf.so: undefined reference to `ntfsv_enc_reader_initialize_2_msg' lib/.libs/libSaNtf.so: undefined reference to `ntfsv_enc_read_next_msg' lib/.libs/libSaNtf.so: undefined reference to `ntfsv_enc_read_finalize_

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-29 Thread Minh Hon Chau
Hi Srinivas, Those symbols should be defined in libntf_common.so, which the libSaNtf.so depends on One possible case I try to see your error, is that I remove the implementation of ntfsv_enc_read_finalize_msg in ntfsv_enc_dec.c, so I got your error: make -C ../../.. bin/ntfread bin/ntfsend

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-30 Thread Srinivas Mangipudy
Hi Minh,   The symbols are defined in the libntf_common.so, but ntfread was not able to refer to these symbols.   After I added “libntf_common.la” in the lib dependency list of ntfread, it worked fine.   I made the below change in Makefile.am file in  “/opensaf-code678/src/ntf” (highlighte

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-01-31 Thread Minh Hon Chau
Hi Srinivas, Thanks for that, but I don't think we should add libntf_common.la to the Makefile.am. These new reader encode/decode functions are introduced in the same way as other existing enc/dec functions, e.g., subscribe_msg, not_msg, and we haven't needed the libntf_common.la so far. C

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-02-01 Thread Srinivas Mangipudy
Hi Minh,   The LD_LIBRARY_PATH env was pointing to the old .so and hence I got the problem. Now it is resolved and the code built successfully.   Thank you Srinivas   From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: Thursday, February 1, 2018 2:27 AM To: Srinivas Mangipudy ; Len

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-02-11 Thread Minh Hon Chau
Hi, A friendly reminder, I'm going to push the PR doc update as there is no comment by today. Thanks, Minh On 29/01/18 15:01, Minh Hon Chau wrote: Hi all, If the patch look ok to you, I would like to push it tomorrow. I have updated the README and PR doc at the below links, if you have

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

2018-02-12 Thread Lennart Lund
Hi Minh I have read the PR document and the README update and have no comments so you have my ACK Thanks Lennart > -Original Message- > From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] > Sent: den 12 februari 2018 00:03 > To: Lennart Lund ; > srinivas.mangip...@oracle.com; Canh Van