[devel] [PATCH 0 of 1] Review Request for IMM: Dumpimg resource utilization data for IMMsv [#35] V2

2014-08-04 Thread reddy . neelakanta
Summary:IMM: Dumpimg resource utilization data for IMMsv [#35] V2 Review request for Trac Ticket(s): 35 Peer Reviewer(s): AndersBj, Zoran Pull request to: Affected branch(es): 4.5(default) Development branch: 4.5 Impacted area Impact y/n ---

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Dumpimg resource utilization data for IMMsv [#35] V2

2014-08-13 Thread Anders Bjornerstedt
Hi Neel, I am reviewing #25 and #957 and I just have an initial comment about immutils. Both patches update immutils (I actually dont remember the reason why #35 needed to update immutils but it must be due to reasons of convenience in the implementation of #35). The problem is that immutils.[h

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Dumpimg resource utilization data for IMMsv [#35] V2

2014-08-13 Thread Neelakanta Reddy
Hi AndersBj, The immutil is updated in #35 because a new utill API immutil_saImmOiAdminOperationResult_o2 is added. Which is used as a part of #35. While pushing the patch, samples/immsv/immutils/ will be updated with new added API. /Neel. On Wednesday 13 August 2014 01:31 PM, Anders Bjorners

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Dumpimg resource utilization data for IMMsv [#35] V2

2014-08-13 Thread Anders Björnerstedt
For each patch you should edit the opensaf immutils, then copy it over the samples immutils. That way you will correct also the omission introduced earlier. Bottom line is that the two samples versions should be identical. There could at some point be a reason for having some samples functionali

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Dumpimg resource utilization data for IMMsv [#35] V2

2014-08-13 Thread Anders Bjornerstedt
Anders Björnerstedt wrote: > Bottom line is that the two samples versions should be identical. > Sigh that should have been "the two immutils versions"... /AndersBj -- ___ O