Summary: IMM: Support admin-op for aborting non critical ccbs [#1107] Review request for Trac Ticket(s): 1107 Peer Reviewer(s): Neel; Zoran Pull request to: Affected branch(es): default(4.7) Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 24e645d723715705aaa1a69290a4e41a7a03ff00 Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com> Date: Wed, 06 May 2015 16:27:56 +0200 IMM: Support admin-op for aborting non critical ccbs [#1107] See the diff for osaf/services/saf/immsv/REAMDE for an explanation of this enhancement. Complete diffstat: ------------------ osaf/libs/common/immsv/include/immsv_api.h | 5 +++-- osaf/services/saf/immsv/README | 33 ++++++++++++++++++++++++++++----- osaf/services/saf/immsv/immnd/ImmModel.cc | 47 +++++++++++++++++++++++++++++++++++++---------- osaf/services/saf/immsv/immnd/ImmModel.hh | 5 +++-- 4 files changed, 71 insertions(+), 19 deletions(-) Testing Commands: ----------------- I tested by hacking tests/immsv/implementer/applier.c to have a sleep of 4 seconds in the completed callback. This i enough time for invoking the admin-operation towards the immsv. The CCB tht is blocked waiting for reply on completed from he OI will get aborted by the admin- operation. Testing, Expected Results: -------------------------- Non critical CCBs existing at the time when the admin-operation is ivoked (roughly) do get aborted. Conditions of Submission: ------------------------- Ack from Neel and Zoran. I have verified that the fix works, so the most important thing to review is that this enhancement does not break some other existing OI-timeout functionality. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel