Summary: Fix saAmfSGNumPrefInserviceSUs handling Review request for Trac Ticket(s): 278 Peer Reviewer(s): Nags Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): all Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 8257ae24773955240b6718ba43611d48ae151f03 Author: Hans Feldt <hans.fe...@ericsson.com> Date: Thu, 24 Apr 2014 07:22:49 +0200 v4 amfd: default saAmfSGNumPrefInserviceSUs to unlimited [#278] When an SG is extended with a new SU, it will not be instantiated or assigned unless saAmfSGNumPrefInserviceSUs is configured accordingly. Reason is saAmfSGNumPrefInserviceSUs is set to number of SUs when the SG is created and is not recalculated as SUs are added. Forcing the user to configure saAmfSGNumPrefInserviceSUs instead of leaving it unconfigured and relying on the default value SU count as specified. This patch sets saAmfSGNumPrefInserviceSUs (when not specifically configured) to unlimited. This mean when an SU is added, nothing needs to be done. It will just be instantiated since number of instantiated SUs is always lower than unlimited. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg.cc | 26 +++----------------------- 1 files changed, 3 insertions(+), 23 deletions(-) Testing Commands: ----------------- add a pre-instantiable SU to an existing SG saAmfSGNumPrefInserviceSUs should not be configured Testing, Expected Results: -------------------------- SU instantiated when SU admin unlocked-instantiated Conditions of Submission: ------------------------- Ack from Nags Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel