Hi,
I think it is starting to look OK now. Just some minor comments.
1) The patch should be split into one for amfd and one for amfnd.
2) There is still one problem remaining in amfd according to valgrind
that needs to be fixed:
==2684== Mismatched free() / delete / delete []
==2684==at
Hi Hans,
Nice work!
I do have some comment that I think needs to be fixed.
amfd:
- main.cc, function rda_cb, memory is allocated with malloc, this is
later returned with delete in avsv_d2d_msg_free() called from
avd_role_change_evh(). I think this malloc should be changed to new
- csiattr.cc,
Hi Hans, thanks, see comments below/BR HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi Hans,
Nice work!
I do have some comment that I think needs to be fixed.
amfd:
- main.cc, function rda_cb
@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi Hans,
Nice work!
I do have some comment that I think needs to be fixed.
amfd:
- main.cc, function rda_cb, memory is allocated with malloc, this is later
returned with delete in avsv_d2d_msg_free() called from
-Original Message-
From: Hans Nordebäck
Sent: den 23 oktober 2013 12:50
To: Hans Feldt
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net; Hans Nordebäck
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi, I guess libs
[mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi Hans,
Nice work!
I do have some comment that I think needs
[mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi Hans,
Nice work!
I do have some comment that I
Summary: amf: replace malloc/calloc with new and delete for amfd and amfnd [#94]
Review request for Trac Ticket(s): #94
Peer Reviewer(s): hansf, nagendra, praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact
