Summary: amfd: create comp if not found during decoding [#761]
Review request for Trac Ticket(s): #761
Peer Reviewer(s): Hans F, Hans N, Praveen
Pull request to:
Affected branch(es) All:
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 8af90929735f1ec74513467e3da3cc3b97617496
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Mon, 03 Feb 2014 12:40:09 +0530
amfd: create comp if not found during decoding [#761] Some times,
because of
timing issues, apply callback is reaching delayed at standby
controller. It
happened during component oper state checkpoiting. Since apply callback
is
not received at standby controller, component is not found in data base
and
counter comp_updt is mismatched during warn sync and standby amfd
asserts.
Fix for this is to create comp when not found in data base and wait for
apply callback. When apply callback comes later, the other parameters
like
su are updated.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 5 +----
osaf/services/saf/amf/amfd/comp.cc | 21 +++++++++++++++++++++
osaf/services/saf/amf/amfd/include/comp.h | 1 +
3 files changed, 23 insertions(+), 4 deletions(-)
Testing Commands:
-----------------
1. Load amf demo configuration when two controllers are up.
2. Delay apply ballback at standby controller.
Without this fix, the below prints will come:
======================================================
Jan 31 19:16:31 PM_SC-181 osafamfd[30345]: ER dec_comp_oper_state: comp not
found, safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
Jan 31 19:16:31 PM_SC-181 osafamfd[30345]: ER dec_comp_oper_state: comp not
found, safComp=AmfDemo1,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
Jan 31 19:16:31 PM_SC-181 osafamfd[30345]: ER dec_comp_oper_state: comp not
found, safComp=AmfDemo,safSu=SU2,safSg=AmfDemo,safApp=AmfDemo1
Jan 31 19:16:31 PM_SC-181 osafamfd[30345]: ER dec_comp_oper_state: comp not
found, safComp=AmfDemo1,safSu=SU2,safSg=AmfDemo,safApp=AmfDemo1
Jan 31 19:17:20 PM_SC-181 osafamfd[30345]: ER Out of sync detected in warm sync
response, exiting
Jan 31 19:17:20 PM_SC-181 osafamfd[30345]: ckpt_dec.cc:3223:
avd_dec_warm_sync_rsp: Assertion '0' failed.
======================================================
Testing, Expected Results:
--------------------------
The above prints should not come and amfd will not crash.
Conditions of Submission:
-------------------------
Ack from peer maintainers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
