Summary: amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]
Review request for Trac Ticket(s): AMF #823
Peer Reviewer(s): Hans F., Hans N., Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please see the commit log below.
changeset 9981f45f79ee507d8a09ee233b7c79b6ccd5ff97
Author: praveen.malv...@oracle.com
Date: Fri, 28 Mar 2014 18:37:49 +0530
amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]
Problem: During si-swap if quiesced assignment faults, AMF returns
BAD_OPERATION even though si-swap completes successfuly after recovery.
Reason: During si-swap, AMF sends quiesced assignment to active SU.
During
quiesced assignments, one of the components faults. AMF performs
cleanup of
this failed component and perfroms the failover of assignments to
standby
SU. For the faulted SU assignments are deleted and when it gets
sucessfully
repaired, AMF assigns it with standby assignments. Thus si-swap
operation
eventually gets successful, but AMF returns BAD_OPERATION for the
operation.
Fix: Since AMF performs si-swap successfuly despite fault in quiesced
state,
this patch ensures that AMF returns SA_AIS_OK for the operation.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 +++++++++++++----------
1 files changed, 13 insertions(+), 10 deletions(-)
Testing Commands:
-----------------
si-swap and fault in the component when
quiesced assignment is going on.
Testing, Expected Results:
--------------------------
Eventually si-swap succeeds and AMF returns SA_AIS_OK to IMM.
Conditions of Submission:
-------------------------
Ack from atleast one reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y y
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
