Summary: amfd: send data verify message to node in NO_CONFIG and NCS_INIT also
[#1359]
Review request for Trac Ticket(s): #1359
Peer Reviewer(s): Praveen, Hans N
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 04e7947a39da3f03db780f8c0a4bb3d60e838755
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Thu, 30 Apr 2015 17:36:38 +0530
amfd: send data verify message to node in NO_CONFIG and NCS_INIT also
[#1359] When Amfd is comming up as Act, it is not sending data verify
message to node, which is in state AVD_AVND_STATE_NO_CONFIG and
AVD_AVND_STATE_NCS_INIT. This creates problem of marking the upcoming
node
in AVD_AVND_STATE_GO_DOWN and this stops that node to join the cluster.
When
node has just come up and sent node up message to Act amfd and at that
time
if Act Amfd node goes for switchover or failover, then that node has to
contact to newly Act Amfd for further communication. So, that node
needs to
get data verify message from newly Amfd.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/ndfsm.cc | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Start SC-1 and SC-2.
Keep sleep of 5 sec in immnd instantiate script on PL-3 and start PL-3.
When PL-3 is waiting for immnd to get instantiated, do a controller switchover
or controller failover.
Testing, Expected Results:
--------------------------
PL-3 should come up.
Conditions of Submission:
-------------------------
Ack from peer reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
