Summary: amfnd: fix process of proxy/proxied termination on OpenSAF shutdown
[#629]
Review request for Trac Ticket(s): #629
Peer Reviewer(s): Hans F, Nagendra
Pull request to:
Affected branch(es): default
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset e14b3510889d13784714b33648d104ec218a64f4
Author: Alex Jones <ajo...@genband.com>
Date: Fri, 02 May 2014 11:59:41 -0400
amfnd: fix process of proxy/proxied termination on OpenSAF shutdown
[#629]
May 2 15:22:11 linux osafamfnd[2990]: NO 'safSu=Management-SU1,safSg
=Management-2N,safApp=ManagementApp' Presence State INSTANTIATED =>
TERMINATION_FAILED May 2 15:22:38 linux osafamfnd[2990]: ER AMF director
unexpectedly crashed May 2 15:22:38 linux osafamfnd[2990]: Rebooting
OpenSAF NodeId = 131343 EE Name =
safEE=Linux_os_hosting_clm_node,safHE=Stir
ling_Blade_slot_1,safDomain=Q50chassis, Reason: local AVD down(Adest) or
both AVD down(Vdest) received, OwnNodeId = 131343, SupervisionTime = 60
May
2 15:22:38 linux opensaf_reboot: Rebooting local node; timeout=60
On OpenSAF shutdown, amfnd doesn't wait for the proxied components of a
proxy to terminate before terminating the proxy. It terminates the proxy
via "CLC-CLI cleanup", and the proxied component via the
SaAmfProxiedComponentCleanupCallbackT in the proxy. If the proxied
component takes some time to terminate, amfnd doesn't wait and
terminates
the proxy. amfnd never gets the response from
SaAmfProxiedComponentCleanupCallbackT (because the proxy has been
terminated), and thinks that the termination of the proxied component
timed
out.
amfnd needs to delay terminating the proxy until all the proxy's proxied
components have have terminated.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/clc.cc | 27 +++++++++++++++++++++++++++
1 files changed, 27 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
1) Create a proxy with one or more proxied components. In the
SaAmfProxiedComponentCleanupCallbackT function, put a delay of a few seconds,
to simulate the shutdown of the proxied component taking some time, before
responding with SA_AIS_OK to the request.
2) perform OpenSAF shutdown "service opensafd shutdown"
Testing, Expected Results:
--------------------------
It should be a clean shutdown with no reboots, no crashes, and no errors.
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
