Summary: amfnd : avoid accessing csi_list in comp after removal of assignments
[#739]
Review request for Trac Ticket(s): AMF #739
Peer Reviewer(s):Hans F., Hans N., Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):All
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please see the commit log below and discussion of #601.
changeset 056307ffd2fa97a4ba04a18629d030cb79b31a20
Author: praveen.malv...@oracle.com
Date: Tue, 04 Feb 2014 15:59:54 +0530
amfnd : avoid accessing csi_list in comp after removal of assignments
[#739]
When AMFND responds to AMFD for the completion of removal of
assignments, it
deletes the SUSI and COMPCSI records. Reported problem appears when a
component receiving multiple CSIs responds to AMFND for the removal of
assignments and AMFND responds to AMFD for the completion of assignment.
Since component has multiple CSIs assigned to it, AMFND tries to again
generate removal completion indication and access csi_list in the
component
which has no nodes in it. This leads to AMFND crash. This patch assures
that
AMFND will not access csi_list in component after deletion of comp_csi
record.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/comp.cc | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Tested as per ticket description.
Testing, Expected Results:
--------------------------
No amfnd crash observed.
Conditions of Submission:
-------------------------
Ack from atleast onre reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y y
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
