Summary: amfnd : avoid multiple clean up of comps during shutdown phase [#890].
Review request for Trac Ticket(s): #890
Peer Reviewer(s): Hans F., Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 97b754c8bc7969648f32f5069e125b41b1ea0e43
Author: praveen.malv...@oracle.com
Date: Mon, 12 May 2014 20:36:39 +0530
amfnd : avoid multiple clean up of comps during shutdown phase [#890].
During shutdown phase, AMFND performs multiple cleanup of components in
a SU
if one of the components moves in TERM_FAILED state.
AMFND launches clean up of all the components during shutdown phase. If
cleanup of one of the components fails then AMFND again launched cleans
up
all the components of the SU as recovery. In this way mutliple clean
ups are
performed for the same component.
Patch checks term_state of avnd control block before launching clean up
of
components in the SU.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/susm.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Bring 4 component application up.
Make arrangmenets such that cleanup script will exit unsuccessfully.
start opensaf shutdown.
Testing, Expected Results:
--------------------------
SU moves to TERM_FAILED state.
No multiple clean up for same component.
Conditions of Submission:
-------------------------
Ack from atleast one reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
