Hi Neelakanta,
1. free() is safe for NULL value and there is no need for extra check.
2. It is not missed.
OM for ccbAugmentInit is OI callback.
Error string is attached to the main CCB (not to augmented CCB), and sending
error string over MDS is skipped:
if(ccb->mVeto != SA_AIS_OK) {
Hi zoran,
Ok, I overlooked the functionality part immnd_evt_ccb_augment_init.
Thanks,
Neel.
On Friday 18 September 2015 06:47 PM, Zoran Milinkovic wrote:
> Hi Neelakanta,
>
> 1. free() is safe for NULL value and there is no need for extra check.
>
> 2. It is not missed.
> OM for
Hi Neelakanta,
Find my answers inline
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, September 04, 2015 11:51 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 1] Review Request for imm: classify abort
Summary: imm: classify abort error strings and prefix existing error strings
[#744]
Review request for Trac Ticket(s): 744
Peer Reviewer(s): Anders, Neelakanta, Hung
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)
Hi Zoran,
Reviewed and tested the patch.
Following are the comments:
1. setCcbErrorString to be added :
ImmModel::ccbObjDelContinuation
if(omuti == ccb->mMutations.end()) {
LOG_WA("object '%s' Not found in ccb - aborting ccb",
objectName.c_str());
if(ccb->mVeto
Summary: imm: classify abort error strings and prefix existing error strings
[#744]
Review request for Trac Ticket(s): 744
Peer Reviewer(s): Neelakanta, Hung
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)
Impacted area
