Summary: pyosaf: add amf/immom subpackage of tools repo under utils of pyosaf 
[#1223]
Review request for Trac Ticket(s): #1223
Peer Reviewer(s): HansF, SrikanthR 
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 4.6(default) 
Development branch: <<IF ANY GIVE THE REPO URL>>

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            y
 RPM/packaging           y
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   y


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 247ffa492501e5b8865a10c71bb913e5e3314a5b
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date:   Wed, 11 Mar 2015 19:21:44 +0530

        pyosaf: add immom subpackage under utils of pyosaf [#1223] Hans created 
the
        opensaf-tools repo and contributed the amf/immom package as a part of 
it.
        The amf/immom package contains useful utilities that can be used by 
other
        packages/tools. This patch moves these opensaf-tools/amf/immom as a
        subpackage of a new utils subpackage under pyosaf of the opensaf staging
        repository. Note: The amf-tools is also adjusted to work with these 
changes
        and will be uploaded to the amf-tools repository separately.


Added Files:
------------
 python/pyosaf/utils/immom/accessor.py
 python/pyosaf/utils/immom/ccb.py
 python/pyosaf/utils/immom/common.py
 python/pyosaf/utils/immom/iterator.py
 python/pyosaf/utils/immom/Makefile.am
 python/pyosaf/utils/immom/object.py
 python/pyosaf/utils/Makefile.am


Complete diffstat:
------------------
 Makefile.common                       |    2 +
 configure.ac                          |    2 +
 opensaf.spec.in                       |    6 +
 python/pyosaf/Makefile.am             |    2 +
 python/pyosaf/utils/Makefile.am       |   24 ++++++
 python/pyosaf/utils/immom/Makefile.am |   27 +++++++
 python/pyosaf/utils/immom/accessor.py |   89 +++++++++++++++++++++++++
 python/pyosaf/utils/immom/ccb.py      |  299 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 python/pyosaf/utils/immom/common.py   |   51 ++++++++++++++
 python/pyosaf/utils/immom/iterator.py |  136 
+++++++++++++++++++++++++++++++++++++++
 python/pyosaf/utils/immom/object.py   |  108 +++++++++++++++++++++++++++++++
 11 files changed, 746 insertions(+), 0 deletions(-)


Testing Commands:
-----------------
1) Accessing any method, object of the pyosaf.utils.immom subpackage
should work.
2) amf-tools should work as before.

Testing, Expected Results:
--------------------------
Same as above.

Conditions of Submission:
-------------------------
Ack from Hans.

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to