Re: [devel] [PATCH 0 of 3] Review Request for logsv: Fix hanging main thread when file i/o dont return [#9]

2013-08-16 Thread Anders Widell
Hi! I have some comments: * Time-out limits shall be configurable (according to our new policy on limits) * I think the use code for killing and re-starting the slave thread is overkill and should be removed. Unless we know (and have seen) that this solves a real problem that can happen in

Re: [devel] [PATCH 0 of 3] Review Request for logsv: Fix hanging main thread when file i/o dont return [#9]

2013-08-16 Thread Anders Widell
...@ericsson.com] Sent: den 16 augusti 2013 10:47 To: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 0 of 3] Review Request for logsv: Fix hanging main thread when file i/o dont return [#9] Hi! I have some comments: * Time-out limits shall be configurable (according to our new

Re: [devel] [PATCH 0 of 3] Review Request for logsv: Fix hanging main thread when file i/o dont return [#9]

2013-08-16 Thread Lennart Lund
-Original Message- From: Anders Widell Sent: den 16 augusti 2013 12:25 To: Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 0 of 3] Review Request for logsv: Fix hanging main thread when file i/o dont return [#9] One more comment: * saf_logger.c