Summary: init with clm before setting up to wait for AMF role [#1781]
Review request for Trac Ticket(s): #1781
Peer Reviewer(s): Praveen/HansN, rameshb, Mahesh
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): opensaf-5.0.x, default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset c73d021bb278e4a36c358040a42988af6d429ec5
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Thu, 28 Apr 2016 19:58:33 +0530
amf: init with clm before entering initialize_for_assignment() [#1781]
With
the introduction of spares support #79, all services were modified to
wait
for AMF role assignment to register with MDS and proceed further with
their
lifecycle. However, this is not necessary and would create a problem of
1781. i.e. All services should ideally register with CLM independent of
their HA roles as provided by AMF or RDA. But ofcourse until now only
AMF,
EVT, CKPT, MSG, NTF, SMF have been integrated with CLM. This patch
makes the
services register with CLM before entering the wait() for AMF role. NTF
service is already handling this correctly. This is also necessary to
make
OpenSAF services run - without abort, on nodes that are administratively
locked/shutdown via CLM node admin commands. A separate patch for SMF
follow.
changeset ec2e88336ce2c177a5ebf451b746e2f3be18406a
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Thu, 28 Apr 2016 19:59:28 +0530
ckpt: init with clm before entering initialize_for_assignment() [#1781]
With
the introduction of spares support #79, all services were modified to
wait
for AMF role assignment to register with MDS and proceed further with
their
lifecycle. However, this is not necessary and would create a problem of
1781. i.e. All services should ideally register with CLM independent of
their HA roles as provided by AMF or RDA. But ofcourse until now only
AMF,
EVT, CKPT, MSG, NTF, SMF have been integrated with CLM. This patch
makes the
services register with CLM before entering the wait() for AMF role. NTF
service is already handling this correctly. This is also necessary to
make
OpenSAF services run - without abort, on nodes that are administratively
locked/shutdown via CLM node admin commands. A separate patch for SMF
follow.
changeset 7b7657005dac63109cf8bc25533df3eb03d0b383
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Thu, 28 Apr 2016 19:59:41 +0530
evt: init with clm before entering initialize_for_assignment() [#1781]
With
the introduction of spares support #79, all services were modified to
wait
for AMF role assignment to register with MDS and proceed further with
their
lifecycle. However, this is not necessary and would create a problem of
1781. i.e. All services should ideally register with CLM independent of
their HA roles as provided by AMF or RDA. But ofcourse until now only
AMF,
EVT, CKPT, MSG, NTF, SMF have been integrated with CLM. This patch
makes the
services register with CLM before entering the wait() for AMF role. NTF
service is already handling this correctly. This is also necessary to
make
OpenSAF services run - without abort, on nodes that are administratively
locked/shutdown via CLM node admin commands. A separate patch for SMF
follow.
changeset 71d9aba65897de980f0a535d6abba3de5eb5dbf5
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Thu, 28 Apr 2016 20:00:01 +0530
msg: init with clm before entering initialize_for_assignment() [#1781]
With
the introduction of spares support #79, all services were modified to
wait
for AMF role assignment to register with MDS and proceed further with
their
lifecycle. However, this is not necessary and would create a problem of
1781. i.e. All services should ideally register with CLM independent of
their HA roles as provided by AMF or RDA. But ofcourse until now only
AMF,
EVT, CKPT, MSG, NTF, SMF have been integrated with CLM. This patch
makes the
services register with CLM before entering the wait() for AMF role. NTF
service is already handling this correctly. This is also necessary to
make
OpenSAF services run - without abort, on nodes that are administratively
locked/shutdown via CLM node admin commands. A separate patch for SMF
follow.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/main.cc | 8 +++++++
osaf/services/saf/amf/amfd/role.cc | 5 ----
osaf/services/saf/cpsv/cpd/cpd_init.c | 94
++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
osaf/services/saf/edsv/eds/eds_api.c | 23 +++++++++++++--------
osaf/services/saf/mqsv/mqd/mqd_api.c | 95
+++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
5 files changed, 127 insertions(+), 98 deletions(-)
Testing Commands:
-----------------
- Start a 3 SC cluster
- Lock the spare SC. i.e. $ immadm -o 2 <DN name of CLM node of spare SC>
- stop opensaf on standby.
Testing, Expected Results:
--------------------------
The spare SC should not go for reboot.
Note: There would be warning/failure messages seen in SMF, but
those would have to be addressed via an enhancement.
The expected result from this patch series is to prevent the node from
rebooting.
Conditions of Submission:
-------------------------
Ack from one of the maintainers for the respective services.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
