Summary: pyosaf: [Round 3] Add Python imm oi utils module and sample
applications [#1406]
Review request for Trac Ticket(s): #1406
Peer Reviewer(s): hans.nordeb...@ericsson.com, mathi.naic...@oracle.com,
hung.d.ngu...@dektech.com.au, srikanth.revan...@oracle.com
Pull request to: srikanth.revan...@oracle.com
Affected branch(es): 4.7.x
Development branch: opensaf-staging
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other y
Comments (indicate scope for each "y" above):
---------------------------------------------
Round 3 - add the sample application to the readme and fix an additional comment
from Hung Nguyen.
changeset a98c3feb8c85a2b84137278d8c80266f3188f8ce
Author: Johan Mårtensson <johan.o.martens...@ericsson.com>
Date: Thu, 20 Aug 2015 13:13:41 +0200
pyosaf: Add Python imm oi utils module and sample applications [#1406]
Add high-level imm oi utils module on top of the direct imm oi Python
bindings. Also add sample applications demonstrating usage both as
subclassing and with direct callbacks.
changeset 51bd4b909527c21fe67095f0840eff2964a26444
Author: Johan Mårtensson <johan.o.martens...@ericsson.com>
Date: Thu, 27 Aug 2015 15:23:53 +0200
pyosaf: Fix handling of attribute updates and associated sample
applications
[#1406]
Fix the handling of updates of runtime attributes on request from IMM.
Add
sample application to demonstrate this, both for direct callbacks and by
using a subclass.
Verify by executing the sample applications:
./users &
immlist usersId=1
or
./users-inheritance-impl &
immlist usersId=2
changeset 13387dffb534c503e6331ea90ae923d7be76297f
Author: Johan Mårtensson <johan.o.martens...@ericsson.com>
Date: Fri, 28 Aug 2015 11:31:48 +0200
pyosaf: Make the users attribute in the UsersSampleClass multivalued
[#1406]
Make the users attribute in the UsersSampleClass multivalued.
changeset 4e923d0e93cab801fc77caf0b11aaab0720dda33
Author: Johan Mårtensson <johan.o.martens...@ericsson.com>
Date: Fri, 28 Aug 2015 11:33:03 +0200
pyosaf: Correct the users inheritance sample OI to use the right IMM
object
[#1406]
Correct the inheritance implementation of the users sample OI to use the
right IMM object.
changeset f1e18c64d86a29a84b997a86efc69422f30ae1aa
Author: Johan Mårtensson <johan.o.martens...@ericsson.com>
Date: Fri, 28 Aug 2015 11:33:33 +0200
pyosaf: Add the users sample OI to the README [#1406]
Add the users sample OI to the README
changeset b6033bc7b99d8d00de4ac3477aee40eed9613fcf
Author: Johan Mårtensson <johan.o.martens...@ericsson.com>
Date: Fri, 28 Aug 2015 15:20:32 +0200
pyosaf: Define DN before using it to filter [#1406]
When building the full content of the CCB on completed, a dn variable of
create was used without defining it. This patch fixes it.
Added Files:
------------
python/pyosaf/utils/immoi/implementer.py
python/pyosaf/utils/immoi/__init__.py
python/samples/immoi/samples/caps
python/samples/immoi/samples/caps-inheritance-impl
python/samples/immoi/samples/classes.xml
python/samples/immoi/samples/imm-listener
python/samples/immoi/samples/imm-listener-inheritance-impl
python/samples/immoi/samples/interface-handler
python/samples/immoi/samples/interface-handler-inheritance-version
python/samples/immoi/samples/ping-pong
python/samples/immoi/samples/ping-pong-inheritance-impl
python/samples/immoi/samples/README
python/samples/immoi/samples/time-reporter
python/samples/immoi/samples/time-reporter-inheritance-impl
python/samples/immoi/samples/tones
python/samples/immoi/samples/tones-inheritance-impl
python/samples/immoi/samples/users
python/samples/immoi/samples/users-inheritance-impl
Complete diffstat:
------------------
python/pyosaf/utils/immoi/__init__.py | 399
++++++++++++
python/pyosaf/utils/immoi/implementer.py | 896
+++++++++++++++++++++++++++
python/pyosaf/utils/immom/__init__.py | 10 +-
python/samples/immoi/samples/README | 93 ++
python/samples/immoi/samples/caps | 42 +
python/samples/immoi/samples/caps-inheritance-impl | 49 +
python/samples/immoi/samples/classes.xml | 203
++++++
python/samples/immoi/samples/imm-listener | 111 +++
python/samples/immoi/samples/imm-listener-inheritance-impl | 158 ++++
python/samples/immoi/samples/interface-handler | 121 +++
python/samples/immoi/samples/interface-handler-inheritance-version | 125 +++
python/samples/immoi/samples/ping-pong | 59 +
python/samples/immoi/samples/ping-pong-inheritance-impl | 53 +
python/samples/immoi/samples/time-reporter | 67 ++
python/samples/immoi/samples/time-reporter-inheritance-impl | 82 ++
python/samples/immoi/samples/tones | 27 +
python/samples/immoi/samples/tones-inheritance-impl | 32 +
python/samples/immoi/samples/users | 30 +
python/samples/immoi/samples/users-inheritance-impl | 34 +
19 files changed, 2590 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
