Re: [devel] [PATCH 00 of 10] Review Request for amfd: convert AVD_SG_OPER to std::list [#1142]

2015-09-03 Thread Nagendra Kumar
I think, we can make a function to check if su_oper_list is empty and then use front() function call as calling this function on empty container results in undefined behaviour. Thanks -Nagu > -Original Message- > From: Gary Lee [mailto:gary@dektech.com.au] > Sent: 29 July 2015 12:06

Re: [devel] [PATCH 00 of 10] Review Request for amfd: convert AVD_SG_OPER to std::list [#1142]

2015-08-11 Thread Gary Lee
Hi Hans Using nullptr sounds like a good idea. Can we do this in a separate patch series? Gary On 07/08/15 21:58, Hans Nordebäck wrote: > ack for the whole series, code review only. Minor comment, all patches > must be applied to compile, > and a question in patch 04. Perhaps we can use c++11

Re: [devel] [PATCH 00 of 10] Review Request for amfd: convert AVD_SG_OPER to std::list [#1142]

2015-08-07 Thread Hans Nordebäck
ack for the whole series, code review only. Minor comment, all patches must be applied to compile, and a question in patch 04. Perhaps we can use c++11 nullptr instead of NULL for pointers? /Thanks HansN On 07/29/2015 08:36 AM, Gary Lee wrote: > Summary: amfd: convert AVD_SG_OPER to std::list [#

[devel] [PATCH 00 of 10] Review Request for amfd: convert AVD_SG_OPER to std::list [#1142]

2015-07-28 Thread Gary Lee
Summary: amfd: convert AVD_SG_OPER to std::list [#1142] Review request for Trac Ticket(s): 1142 Peer Reviewer(s): AMF devs Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n