[devel] [PATCH 01 of 12] amfd : use db_template in AVD_SVC_TYPE_CS_TYPE [#713]

2014-06-04 Thread praveen . malviya
osaf/services/saf/amf/amfd/include/si.h | 4 +-- osaf/services/saf/amf/amfd/si.cc | 3 -- osaf/services/saf/amf/amfd/svctypecstypes.cc | 40 +++ 3 files changed, 12 insertions(+), 35 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h

Re: [devel] [PATCH 01 of 12] amfd : use db_template in AVD_SVC_TYPE_CS_TYPE [#713]

2014-06-04 Thread Hans Nordebäck
Hi Praveen, one comment inline below/Regards HansN -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 4 juni 2014 12:20 To: Hans Nordebäck; Hans Feldt; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 01 of 12]

Re: [devel] [PATCH 01 of 12] amfd : use db_template in AVD_SVC_TYPE_CS_TYPE [#713]

2014-06-04 Thread praveen malviya
- rc = si_db-insert(Amf::to_string(si-name), si); - osafassert(rc == NCSCC_RC_SUCCESS); In my original patch this change is not there. I am attaching the patch. Thanks Praveen On 04-Jun-14 5:14 PM, Hans Nordebäck wrote: Hi Praveen, one comment inline below/Regards

Re: [devel] [PATCH 01 of 12] amfd : use db_template in AVD_SVC_TYPE_CS_TYPE [#713]

2014-06-04 Thread Hans Nordebäck
ack, code review only/Thanks HansN -Original Message- From: praveen malviya [mailto:praveen.malv...@oracle.com] Sent: den 4 juni 2014 14:17 To: Hans Nordebäck Cc: Hans Feldt; nagendr...@oracle.com; opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 01 of 12] amfd : use db_template