When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and saAmfResponse_4 should return SA_AIS_ERR_BAD_HANDLE
instead of SA_AIS_ERR_VERSION as previously done.
---
src/amf/agent/amf_agent.cc | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/amf/agent/a
ack, code review only.
When refactoring the code, perhaps UINT_MAX from can be used
instead of AVSV_UNS32_HDL_MAX?
And PRIx64 from instead of %llx?
/Regards HansN
On 08/02/2017 06:01 AM, Nguyen Luu wrote:
When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and sa
UINT32_MAX from is a better constant here since we are dealing
with a 32-bit integer.
regards,
Anders Widell
On 08/02/2017 09:19 AM, Hans Nordebäck wrote:
ack, code review only.
When refactoring the code, perhaps UINT_MAX from can be used
instead of AVSV_UNS32_HDL_MAX?
And PRIx64 from
Thanks, Hans and Anders, for your review.
About the code refactoring, should we do it in a separate ticket for all
AMF API's that use such constant and format specifier? That should be an
enhancement rather than a defect ticket like this one.
Thanks,
Nguyen
On 8/2/2017 6:16 PM, Anders Widell
Hi,
I'd like to push this patch tomorrow if there are no more comments.
Thanks,
Nguyen
On 8/7/2017 2:00 PM, Nguyen Luu wrote:
Thanks, Hans and Anders, for your review.
About the code refactoring, should we do it in a separate ticket for
all AMF API's that use such constant and format specifi
Ack, code review only.
Thanks
Praveen
On 02-Aug-17 9:31 AM, Nguyen Luu wrote:
When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and saAmfResponse_4 should return SA_AIS_ERR_BAD_HANDLE
instead of SA_AIS_ERR_VERSION as previously done.
---
src/amf/agent/amf_agent.cc
