[devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-07-26 Thread Praveen
SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way Active model. AMF is assigning more than saAmfSGNumPrefAssignedSUs in both N-Way and N-Way Active model. Patch fixes this problem. --- src/amf/amfd/sg.cc | 49 -- src/amf/

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-08-08 Thread Hans Nordebäck
Hi Praveen, ack, code review only, minor comments below. /Regards HansN On 07/27/2017 07:36 AM, Praveen wrote: SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way Active model. AMF is assigning more than saAmfSGNumPrefAssignedSUs in both N-Way and N-Way Active model. Pa

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-08-30 Thread Gary Lee
Hi Praveen ack, but I think further changes are required (see attachment). Do you think you could push it today? Thanks Gary On 27/07/17 15:36, Praveen wrote: SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way Active model. AMF is assigning more than saAmfSGNumPrefAssign

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-08-30 Thread praveen malviya
Hi Gary, ack for part2. I think I did not grep on saAmfSGNumPrefInserviceSUs in all files. I have pushed part1. Please push part2. Thanks Praveen On 31-Aug-17 9:50 AM, Gary Lee wrote: Hi Praveen ack, but I think further changes are required (see attachment). Do you think you could push it

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-08-30 Thread Gary Lee
OK - thanks. Should we push it to release as well? On 31/08/17 15:30, praveen malviya wrote: Hi Gary, ack for part2. I think I did not grep on saAmfSGNumPrefInserviceSUs in all files. I have pushed part1. Please push part2. Thanks Praveen On 31-Aug-17 9:50 AM, Gary Lee wrote: Hi Praveen

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-08-30 Thread praveen malviya
I am not seeing any milestone for any maintenance/release branch. There is only one milestone 5.17.10 which is for new release. Thanks Praveen On 31-Aug-17 11:34 AM, Gary Lee wrote: OK - thanks. Should we push it to release as well? On 31/08/17 15:30, praveen malviya wrote: Hi Gary,  ack

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

2017-08-30 Thread praveen malviya
I got confused with previous release strategies. Please push in release branch also. Thanks Praveen On 31-Aug-17 11:48 AM, praveen malviya wrote: I am not seeing any milestone for any maintenance/release branch. There is only one milestone 5.17.10 which is for new release. Thanks Prave