[devel] [PATCH 1/1] amfnd: correct handling "terminate success" evt in terminating state [#3157]

2020-02-19 Thread Thang Duc Nguyen
Amfnd need to exist in node in shutdown state and all components terminated. --- src/amf/amfnd/clc.cc | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/src/amf/amfnd/clc.cc b/src/amf/amfnd/clc.cc index de57838c9..f78e1a707 100644 --- a/s

Re: [devel] [PATCH 1/1] amfnd: correct handling "terminate success" evt in terminating state [#3157]

2020-02-20 Thread Thuan Tran
Hi Thang, 2 comments (code review, not test) - The function name should be: "avnd_clean_and_exit" - Conditions for call the function sometimes only "all_comps_terminated()" sometimes with SHUTDOWN_STARTED. Can you check if we can make conditions consistent (only one or always two)? Best Regards,

Re: [devel] [PATCH 1/1] amfnd: correct handling "terminate success" evt in terminating state [#3157]

2020-02-20 Thread Thang Duc Nguyen
Hi Thuan, See my comment inline. -Original Message- From: Thuan Tran Sent: Thursday, February 20, 2020 4:17 PM To: Thang Duc Nguyen ; Minh Hon Chau ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] amfnd: correct handling "terminate success" evt in terminatin

Re: [devel] [PATCH 1/1] amfnd: correct handling "terminate success" evt in terminating state [#3157]

2020-02-20 Thread Minh Hon Chau
Hi Thang, ack (not tested), would be good if you can elaborate the commit message to explain how/why the patch can fix coredump. Thanks Minh On 20/2/20 5:27 pm, Thang Duc Nguyen wrote: Amfnd need to exist in node in shutdown state and all components terminated. --- src/amf/amfnd/clc.cc |